* Fix lint issues: Replace golint with revive
golint is deprecated and recommended to be replaced with revive
* Updating comments to be more accurate
* Updating comments again
Co-authored-by: Azeem Shaikh <azeemshaikh38@gmail.com>
* Fix lint issues: whitespace linter
* Fix lint issues: wrapcheck linter
* Fix lint issues: errcheck linter
* Fix lint issues: paralleltest linter
* Fix lint issues: gocritic linter
Most changes from this commit are from passing checker.CheckResult by reference and not by value. gocritic identified that as a huge parameter.
gocritic also prefers regexp.MustCompile over Compile when the pattern is a const
See
$ go run . --repo=https://github.com/protocolbuffers/protobuf --show-details --checks=Code-Review
Starting [Code-Review]
Finished [Code-Review]
RESULTS
-------
Code-Review: Pass 9
found different author and committer for pr: 8053
found different author and committer for pr: 8052
found review approved pr: 8048
found review approved pr: 8045
found different author and committer for pr: 8043
found review approved pr: 8035
found review approved pr: 8032
found review approved pr: 8030
found review approved pr: 8029
found review approved pr: 8028
found review approved pr: 8026
found review approved pr: 8025
found review approved pr: 8024
found review approved pr: 8023
found review approved pr: 8022
found different author and committer for pr: 8014
found different author and committer for pr: 8013
found review approved pr: 8011
found review approved pr: 8010
found review approved pr: 8006
found review approved pr: 8005
found different author and committer for pr: 8003
found review approved pr: 8000
found different author and committer for pr: 7997
github code reviews found
PR review policy is good to check but keep its confidence low
since actual enforcement is checked by GithubCodeReview and
ProwCodeReview and those values should be used.