Nathan Sobo
f9a576b0ce
Allow Infinity for initialLine/Column; move specs to workspace
...
The initialLine and initialColumn behavior belongs on workspace.
2015-08-10 11:32:38 -06:00
Nathan Sobo
69da157ecb
Add specs for initialLine and initialColumn, simplify implementation
2015-08-10 11:27:15 -06:00
Max Brunsfeld
d9aa95fb11
Fix specs to deal w/ async ServiceHub::consume
2015-07-23 11:31:09 -07:00
Ivan Žužak
852456fafe
Merge pull request #7173 from atom/ns-prompt-on-large-files
...
Show a warning prompt when opening files over 20MB
2015-06-21 18:17:59 +02:00
Michael Bolin
ad46b37cfe
In workspace-spec.coffee, updated FakeSearch to match the spec, which
...
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4
Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
...
This reverts commit 262d41c306
2015-06-10 23:30:25 +01:00
Max Brunsfeld
262d41c306
Revert "Introduce atom.directory-searcher service v0.1.0."
2015-06-09 11:51:30 -07:00
Michael Bolin
0630bce95c
Two things:
...
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
028ac79836
Changed the behavior so that if a searcher rejects,
...
then the thenable returned by `atom.workspace.scan()` rejects.
2015-06-09 15:34:09 +01:00
Michael Bolin
7dc3d07f8a
Changed the contract of DefaultDirectorySearcher in two significant ways:
...
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
318498464a
Responded to all of @maxbrunsfeld's comments except for:
...
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.
I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
5fc9d9e01a
Document and test the cancel() method on the object returned by atom.workspace.scan().
2015-06-09 15:34:09 +01:00
Michael Bolin
10d9111f68
Clean up test to verify that an individual failed search fails the overall search.
2015-06-09 15:34:09 +01:00
Michael Bolin
898f7b87e8
remove require for Disposable that is no longer needed
2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f
Make delegate method names more delegate-like.
2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925
Switch to the delegate pattern,
...
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
4330c3a181
Fix some nits I found during my self-review.
2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4
Change DirectorySearcher to return a DirectorySearch.
2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2
Introduce atom.directory-searcher service v0.1.0.
...
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.
This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00
Nathan Sobo
5c57cb0cfe
Show a warning prompt when opening files over 20MB
...
We still have some trouble on files this large. I want to show a
progress bar, but for now this is better than freezing without any
warning at all.
2015-06-09 00:02:36 +02:00
Nathan Sobo
df733aa3de
Add a basic test for opening an editor in largeFileMode if >= 2MB
2015-06-05 23:25:48 +02:00
Nathan Sobo
ffcebdad33
Remove outdated test
2015-06-05 23:14:11 +02:00
Machiste Quintana
d5bcc0433d
WIP: 👕 Fix linter errors
2015-05-22 16:29:12 -04:00
Machiste Quintana
4fb58317ec
🔥 Redundant lines
2015-04-30 13:41:47 -04:00
Machiste Quintana
2bd7cc9a99
Reset font size if editor.fontSize is changed from anywhere
2015-04-28 22:58:35 -04:00
Machiste Quintana
12b59cf610
Only reset font size if font size has been changed
2015-04-28 06:27:03 -04:00
Machiste Quintana
f4b228c908
Reset font size to window's starting font size
2015-04-28 06:27:03 -04:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00
Max Brunsfeld
cbefdd6c5e
Make Workspace::scan work w/ multiple root directories
2015-02-24 14:22:39 -08:00
Kevin Sawicki
5de95759cd
Spy on editor.save
2015-02-05 15:24:00 -08:00
postcasio
867f920329
Handle EROFS errors when saving
2015-01-20 09:56:00 +00:00
Ben Ogle
11bda1b47a
Add error handling for EBUSY as well
2015-01-16 11:07:32 -08:00
Ben Ogle
93f109fbba
Add a better message for EPERM errors.
2015-01-16 10:45:48 -08:00
Ben Ogle
3454249b58
Allow ENOENT errors in project.open
2015-01-14 16:15:52 -08:00
Ben Ogle
cbd42ac20c
Don’t need the pane in workspace.open
2015-01-14 16:15:52 -08:00
Ben Ogle
8435826e8a
Remove linter errors
2015-01-14 16:15:52 -08:00
Ben Ogle
16468eb65d
Move workspace specs to workspace.
2015-01-14 16:15:52 -08:00
Ben Ogle
c20d3a8182
Throw an error when the error is unhandled
2015-01-14 16:15:51 -08:00
Ben Ogle
ca1f66d197
Post a notification when the user cannot access a file
2015-01-14 16:15:51 -08:00
Ben Ogle
4138b95146
Remove unnecessary < chars. wtf
2015-01-14 16:15:51 -08:00
Ben Ogle
11d4222c9f
Handle error when opening a file that doesn’t exist
2015-01-14 16:15:51 -08:00
Ben Ogle
bc454f14e0
Add a warning notification for oversize file open
2015-01-14 16:15:51 -08:00
Nathan Sobo
e60a9e45f7
Display package name correctly for ::getUri deprecation warnings
...
We capture the package name during the call to ::addOpener and use it
if any open items have the deprecated ::getUri method.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-01-14 14:23:17 -07:00
Nathan Sobo
7f8ab72f53
Capitalize initialisms
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-01-12 22:00:24 -08:00
Nathan Sobo
d26c19a0ec
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project. This adds a new private method on
Project, ::resolvePath, with the original implementation for convenience
until we actually implement multi-folder projects.
2015-01-09 15:03:07 -08:00
Nathan Sobo
19bf64f3cd
Revert "Deprecate Project::resolve"
...
This reverts commit 3c5bd9f10a
2015-01-09 13:58:01 -08:00
Nathan Sobo
3c5bd9f10a
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project.
2015-01-09 13:40:35 -08:00
Nathan Sobo
bdfc862dac
Move Project::replace to Workspace
2014-12-29 11:43:17 -06:00
Nathan Sobo
2c7aa170e9
Move Project::scan to Workspace
2014-12-29 11:35:07 -06:00
Max Brunsfeld
aecd689593
Call Workspace::getActiveTextEditor, not ::getActiveEditor
2014-12-04 08:57:33 -08:00
