Katrina Uychaco
67d49955f1
Add tests for pending pane items
2016-01-05 10:38:13 -08:00
Eli Fatsi
84a6f0cb75
Remap pane:show-item-9 to activate last pane item
2015-11-11 10:09:09 -07:00
Nathan Sobo
84aa8471b4
Pass AppDelegate to Workspace, Pane instead of bound functions
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-13 18:54:48 -06:00
Max Brunsfeld
369f3d2648
Don't use atom.{notifications,config,deserializers,confirm} in Pane
...
Still need to get rid of one use of showSaveDialogSync
2015-10-09 17:18:26 -07:00
Nathan Sobo
4808c9f9e8
Eliminate config and confirm global references in Pane
2015-10-07 16:32:47 -05:00
Max Brunsfeld
9924288a6f
Use atom environment argument to deserialize in Pane, PaneAxis
2015-10-07 15:25:05 -05:00
Nathan Sobo
fd7fbbfea5
Move PaneContainer.deserialize to an instance method
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-07 15:24:55 -05:00
Nathan Sobo
ddb08d0c46
Avoid redundant onDidAddPaneItem notifications
...
Refs #9012
2015-10-05 12:34:49 -06:00
Nathan Sobo
b3b7b3f3dd
Don’t use Serializable mixin in Pane
2015-09-22 10:37:15 -06:00
Nathan Sobo
3a1f103620
Get pane-spec passing without using model superclass
2015-09-22 10:37:07 -06:00
George Ogata
45694dcda0
Fire event before a pane is destroyed.
2015-07-23 18:47:38 -04:00
Nathan Sobo
8348b2c039
Throw exception when adding a non-object pane item
2015-07-01 13:29:13 -05:00
George Ogata
8a5dfeae05
Add Pane::onWillRemoveItem event.
2015-06-24 00:16:45 -04:00
Jesse Grosjean
05e6d9e55d
Stop focusing specs on "Pane"
2015-06-06 22:22:47 -04:00
Jesse Grosjean
f88e21cbb0
Allow items to provide savePanel options.
2015-06-06 22:21:51 -04:00
liuxiong332
412fbdef54
add specs for pane's serialization
2015-04-14 21:31:59 +08:00
Kevin Sawicki
e51c8f3407
Add specs for save/saveAs error handling
2015-02-05 15:07:42 -08:00
Nathan Sobo
7f8ab72f53
Capitalize initialisms
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-01-12 22:00:24 -08:00
Ben Ogle
af052c79a7
nof
2014-11-10 13:32:58 -08:00
Ben Ogle
6159209d49
moveItemTo* -> moveItem*
2014-11-10 13:28:15 -08:00
Ardeshir Javaherchi
5e3b88f42d
Add another test for moveItemToLeft
2014-11-10 11:25:17 -08:00
Ardeshir Javaherchi
a0e4d8b582
✅ Add test for reordering tabs in linux
2014-11-10 11:25:17 -08:00
Nathan Sobo
efd3329c50
Prompt to save modified items when closing a pane via pane:close
...
Fixes #4094
2014-11-10 07:55:37 -07:00
Nathan Sobo
33a5ca30dc
Use DeserializerManager::add disposable instead of ::remove in specs
2014-09-30 12:58:10 -06:00
Nathan Sobo
55cce48af1
Throw an exception if the same pane item is added twice in the workspace
2014-09-19 16:24:13 -06:00
Ben Ogle
a81393320c
Support a copyActiveItem param in Pane::split* methods
2014-09-04 16:41:20 -07:00
Nathan Sobo
b60b9f3e3a
Add Pane::observeItems
2014-08-28 16:40:54 -06:00
Nathan Sobo
44d70aaa5b
Add Pane::onDidChangeActive()
2014-08-28 11:43:07 -06:00
Nathan Sobo
2b63f8a4ee
Add PaneContainer::onDidChangeActivePane
2014-08-28 11:43:07 -06:00
Nathan Sobo
8225f759bf
Add Pane::onWillDestroyItem()
2014-08-28 11:43:07 -06:00
Nathan Sobo
2d58d9c8b5
Add Pane::onDidActivate
2014-08-28 11:43:07 -06:00
Nathan Sobo
548018e9b2
Add spec for onDidRemoveItem observers when moving items to other panes
2014-08-28 11:43:07 -06:00
Nathan Sobo
9bd2eec4bc
Add Pane::onDidMoveItem()
2014-08-28 11:43:07 -06:00
Nathan Sobo
b8fcbe9451
Start adding event subscription methods to pane
...
This branch uses EventKit, an ultra-simple library for implementing
events. The object implementing the methods maintains its own emitter
object rather than doing a mixin like Emissary encourages. This will
make it easier for us to deprecate ::on on the object itself. Unlike
emissary, the EventKit Emitter implements a super minimalistic API that
only allows one value to be emitted and always returns a Disposable
from subscriptions.
2014-08-28 11:43:06 -06:00
Nathan Sobo
ebb02bcd37
Use public getters instead of properties in pane-spec
2014-08-28 11:42:42 -06:00
Nathan Sobo
8521114c08
Fix failures associated with not passing focused: true on pane splits
2014-06-09 17:09:02 +09:00
Kevin Sawicki
864ab0c095
Use file path in save as dialog
...
Previously the dirname of the file path was used which caused the
save dialog to not be filled in with the current file name
Closes #1748
2014-03-12 18:41:50 -07:00
Brandon Tilley
8bba4d8add
Intelligently activate new items when the active item is closed
...
If the active item was the pane's first item, the second item (which is
the new first item) is activated. Otherwise, the item to the left of the
closed item is activated.
2014-01-20 14:34:02 -08:00
Kevin Sawicki
e0cf20cda9
Don't throw error when saving empty pane
...
Closes #1440
2014-01-17 15:24:55 -08:00
Nathan Sobo
926493f05c
Emit 'item-added' before setting the ::activeItem when adding first item
...
Fixes atom/tabs#11
2014-01-17 11:10:17 -07:00
Nathan Sobo
9af4b14716
Never allow PaneContainer::root to be null
2014-01-15 16:07:47 -07:00
Nathan Sobo
aed9f18457
Accivate the first added pane item
2014-01-15 16:07:47 -07:00
Nathan Sobo
012363a785
Null guard item in ::destroyActiveItem
2014-01-15 16:07:47 -07:00
Nathan Sobo
44331d0ba6
Fix issues splitting panes with DOM events
...
* ::copyActiveItem guards against not having an active item
* The Pane constructor removes undefined items from params.items
2014-01-15 16:07:47 -07:00
Nathan Sobo
fe7c5b4bc1
Only destroy an empty panes if 'core.destroyEmptyPanes' is true
2014-01-15 16:07:47 -07:00
Nathan Sobo
1c6564f7a5
Move non-focus serialization specs from pane-view-spec to pane-spec
2014-01-14 21:39:47 -07:00
Nathan Sobo
d9d28b5236
Move ::itemForUri specs from pane-view-spec to pane-spec
2014-01-14 20:39:13 -07:00
Nathan Sobo
8734eab8cb
💄 Give dummy pane items ::getUri and ::getPath methods
2014-01-14 20:38:07 -07:00
Nathan Sobo
9841a3588f
Move specs on PaneView::remove to Pane::destroy in pane-spec
2014-01-14 20:10:01 -07:00
Nathan Sobo
d8ddd52df8
Move ::activateItemAtIndex specs from pane-view-spec to pane-spec
2014-01-14 19:49:15 -07:00
