Max Brunsfeld
578b4f0281
Merge branch 'master' into mb-use-language-mode-api
2017-11-21 15:00:22 -08:00
Max Brunsfeld
be3010e8f7
Use atom's null grammar when assignLanguageMode is called w/ null
2017-11-21 14:59:42 -08:00
Wliu
64b4954492
Improve spec stack traces
2017-11-21 23:35:26 +01:00
Wliu
ebf23ec3e1
Do not clobber recent project history when running specs
2017-11-21 21:19:05 +01:00
Max Brunsfeld
218eb57f3a
Avoid duplicate attachToDOM call
2017-11-21 12:00:54 -08:00
Max Brunsfeld
cbd55cd921
Fix incorrectly written async test
2017-11-21 11:57:57 -08:00
Max Brunsfeld
aa1f5dde83
Fix TextEditor tests
2017-11-20 16:49:56 -08:00
Max Brunsfeld
6bf32b5ce8
Fix Workspace spec
2017-11-20 16:45:05 -08:00
Max Brunsfeld
cb89562f63
Avoid TokenizedBuffer.setGrammar in TokenIterator test
2017-11-20 16:34:44 -08:00
Max Brunsfeld
d52c4bc33b
Serialize the grammar registry
2017-11-20 14:50:00 -08:00
Max Brunsfeld
b2fcb0cbe2
Integrate the 2 grammar registry specs
2017-11-20 13:53:19 -08:00
Max Brunsfeld
8a52fd1237
Get TokenizedBuffer tests passing
2017-11-20 13:33:09 -08:00
Max Brunsfeld
20bf705000
Destroy editors after text editor component specs
...
This only now became necessary because TokenizedBuffer now *always*
receives a reference to the Atom config on construction, and always
tries to read from it when isFoldableAtRow is called, which can happen
after test cleanup due to resize observers.
2017-11-20 11:59:21 -08:00
Wliu
f277b650e3
Update Pane specs to account for async save dialog behavior
2017-11-20 19:30:39 +01:00
Max Brunsfeld
f6c2e0eba4
Allow setting the null language mode w/ assignLanguageMode(buffer, null)
2017-11-20 09:48:00 -08:00
Wliu
0ba6517a41
Update Workspace specs for async confirm
2017-11-19 01:21:15 +01:00
Wliu
4fdee7bb8f
Update Pane specs for async confirm
2017-11-19 01:12:23 +01:00
Wliu
f960b43782
Update PaneContainer specs for async confirm
2017-11-19 01:06:20 +01:00
Wliu
f6abe9a555
Oops
2017-11-19 01:05:53 +01:00
Wliu
b5c4336a30
Update CommandInstaller specs for async confirm
2017-11-19 01:02:23 +01:00
Wliu
58f351e598
Update AtomEnvironment specs for async confirm
2017-11-19 01:02:10 +01:00
Wliu
f4bdbe87a0
Update message box mocking
2017-11-19 01:01:45 +01:00
Max Brunsfeld
3d5cc6993c
Merge branch 'master' into mb-use-language-mode-api
2017-11-17 14:03:37 -08:00
Michelle Tilley
cb1d529d64
Merge remote-tracking branch 'origin/master' into wl-async-context-menu
2017-11-17 10:16:30 -08:00
Tony Brix
fe4df885d6
add tests
2017-11-16 00:29:24 -06:00
Max Brunsfeld
91d4f53b28
Use assignLanguageMode in TextEditorComponent spec
2017-11-15 17:15:32 -08:00
Max Brunsfeld
653ecd7f52
Merge branch 'master' into mb-use-language-mode-api
2017-11-15 12:52:36 -08:00
Wliu
a59913f51c
Update specs
2017-11-15 21:49:43 +01:00
Michelle Tilley
fdf0478a77
Merge pull request #16191 from atom/Xapphire13-tests
...
Fix merge conflicts for #15415 (Adding option to skip main process tests. Cleaning up resources in tests)
2017-11-15 09:42:16 -08:00
Michelle Tilley
e77ed412b7
Merge branch 'tests' of https://github.com/Xapphire13/atom into Xapphire13-tests
2017-11-15 00:14:44 -08:00
Nathan Sobo
ad1328db5a
Revert "Merge pull request #16092 from atom/autoscroll-after-fold-or-unfold"
...
This reverts commit 6227ecebed
, reversing
changes made to 311055c575
.
2017-11-14 12:17:50 -07:00
Nathan Sobo
e21c757682
Merge pull request #16114 from atom/b3-scroll-linux
...
Use wheelDelta instead of delta in the scroll handler
2017-11-14 06:45:48 -07:00
Ash Wilson
9a0ad46739
Ensure app windows launch in the order we assert they do
2017-11-13 09:51:23 -05:00
Jason Rudolph
dd8173fc35
Merge pull request #16144 from atom/fix-jquery-handling-in-tooltip-manager-add-method
...
Fix handling of jQuery objects in `TooltipManager.add` method
2017-11-09 11:05:47 -05:00
Max Brunsfeld
6c99872040
Merge pull request #16141 from atom/mb-decaf-atom-environment
...
Convert AtomEnvironment to JS
2017-11-08 22:33:01 -08:00
Max Brunsfeld
bc774773f7
Convert AtomEnvironment to JS
2017-11-08 16:44:46 -08:00
Jason Rudolph
fb74992454
Enhance test to catch bug reported in #16135
...
Enhance the fake jQuery object to more closely match a real jQuery
object. With this change, the test fails, thus allowing us to reproduce
the regression reported in #16135 .
2017-11-08 17:44:32 -05:00
Max Brunsfeld
ff8ecf1a49
Fix errors when passing subword regex to native find methods
2017-11-08 14:00:00 -08:00
Max Brunsfeld
7bae4e7324
Use dedent for multiline template strings in text-editor-spec
2017-11-08 11:57:04 -08:00
Nathan Sobo
6227ecebed
Merge pull request #16092 from atom/autoscroll-after-fold-or-unfold
...
Autoscroll to cursor position after folding or unfolding
2017-11-07 11:33:22 -07:00
Jason Rudolph
311055c575
Merge pull request #16091 from atom/decaf-text-utils
...
☠☕ Decaffeinate text-utils
2017-11-07 08:12:59 -05:00
Max Brunsfeld
786f8b6a93
Use await instead of waitsForPromise in atom-environment-spec
2017-11-06 17:51:49 -08:00
Max Brunsfeld
31eafc4622
Convert atom-environment-spec to JS
2017-11-06 17:32:29 -08:00
Max Brunsfeld
20b0fc688d
Use assignLanguageMode in TextEditor spec
2017-11-06 17:18:53 -08:00
Max Brunsfeld
fe6b385c97
Move largeFileMode logic to TokenizedBuffer
2017-11-06 17:07:23 -08:00
Max Brunsfeld
3d36455885
Make getNonWordCharacters take a position
2017-11-06 17:07:23 -08:00
Linus Eriksson
9f83c4b15b
And don't focus the test
2017-11-06 23:55:24 +01:00
Linus Eriksson
bea8094765
Make the tests pass
2017-11-06 23:53:55 +01:00
Max Brunsfeld
4ec1d85aad
Merge branch 'master' into mb-use-language-mode-api
2017-11-06 11:32:52 -08:00
Max Brunsfeld
6e0b629389
Use async and await in git-repository-spec
2017-11-06 10:57:46 -08:00
Max Brunsfeld
275fb0eb36
Convert GitRepository spec to JS
2017-11-06 10:25:31 -08:00
Max Brunsfeld
351f96d5dd
Iterate on GrammarRegistry APIs
...
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-11-06 09:36:06 -08:00
Jason Rudolph
935c63932f
Merge pull request #16090 from atom/decaf-token-iterator
...
☠☕ Decaffeinate TokenIterator
2017-11-06 09:25:10 -05:00
Jason Rudolph
761fa46863
Merge pull request #16073 from atom/decaf-theme-manager-spec
...
☠☕ Decaffeinate spec/theme-manager-spec.coffee
2017-11-04 08:29:12 -04:00
Max Brunsfeld
e6c3891e62
Assign a language mode in text editor component specs
2017-11-03 15:08:02 -07:00
Nathan Sobo
a1e8d25e55
Autoscroll to cursor position after folding or unfolding
...
There were several different fold/unfold code paths, so I decided to
weave simple autoscroll assertions into the existing tests.
2017-11-03 09:57:29 -06:00
Jason Rudolph
3a42785678
☠ ☕ Decaffeinate spec/text-utils-spec.coffee
2017-11-03 08:21:01 -04:00
Jason Rudolph
7b5837afb8
☠ ☕ ☕ Decaffeinate spec/token-iterator-spec.coffee
2017-11-03 07:53:28 -04:00
Michelle Tilley
a3bb0bbb44
Merge pull request #15935 from atom/mkt-core-uri-handlers
...
Add core URI handlers
2017-11-02 18:40:00 -07:00
Ash Wilson
809a2d6348
Merge pull request #16080 from atom/fb-hw-directory-watcher
...
Allow directory providers to implement a custom onDidChangeFiles
2017-11-02 18:30:59 -07:00
Michelle Tilley
0267829211
Change the way we test this
2017-11-02 16:45:52 -07:00
Michelle Tilley
fba5fbc42d
Merge remote-tracking branch 'origin/master' into mkt-core-uri-handlers
2017-11-02 16:30:29 -07:00
Michelle Tilley
99bef8e7d1
More debugging
2017-11-02 16:09:57 -07:00
Michelle Tilley
444597c845
Let's add some debugging
2017-11-02 15:49:06 -07:00
Michelle Tilley
178756b62a
✅ update test
2017-11-02 15:27:59 -07:00
Michelle Tilley
ada75ed1dd
Fix bug in test
2017-11-02 14:45:14 -07:00
Michelle Tilley
668397c1d0
Fix flaky test
2017-11-02 14:11:52 -07:00
Nathan Sobo
d0587a0b60
Merge pull request #16075 from atom/fix-select-word
...
Fix select-word command between word and non-word chararacters
2017-11-02 14:41:39 -06:00
Michelle Tilley
db0fd527ce
Add test for core URI handler window-selection logic
2017-11-02 13:35:29 -07:00
Max Brunsfeld
0d6c746572
Add grammar registry as an injected dependency of Project
2017-11-02 12:24:11 -07:00
Max Brunsfeld
1a7ea3322e
🎨 project-spec.js
2017-11-02 12:13:31 -07:00
hansonw
303cf30b51
Allow directory providers to implement onDidChangeFiles for custom pathwatchers
2017-11-02 11:43:33 -07:00
Max Brunsfeld
99f90af427
Convert Selection spec to JS
2017-11-02 09:48:00 -07:00
Nathan Sobo
1e9753d8a5
Fix select-word command between word and non-word chararacters
...
In #15776 , we accidentally stopped passing an option to the wordRegExp
method that caused us to prefer word characters when selecting words at
a boundary between word and non-word characters.
2017-11-02 10:22:22 -06:00
Jason Rudolph
7054eefe1d
☠ ☕ Decaffeinate spec/theme-manager-spec.coffee
2017-11-02 09:20:08 -04:00
Max Brunsfeld
6277459691
Merge pull request #16066 from atom/mb-decaffeinate-text-editor
...
Convert TextEditor class to JS
2017-11-01 22:25:44 -07:00
Max Brunsfeld
96e6b3a2ce
Fix error in .getLongTitle when editor isn't in the workspace
2017-11-01 16:51:01 -07:00
Max Brunsfeld
616ebe71d9
Convert text-editor-spec.coffee to JavaScript
2017-11-01 15:51:14 -07:00
Nathan Sobo
f25570f135
Exclude Shift from keydown events that terminate selection drags
2017-11-01 14:00:43 -06:00
Nathan Sobo
11511f27d5
Don't terminate selection dragging when a modifier key is pressed
...
This preserves the ability to add selections via ctrl- or cmd-click.
2017-11-01 09:22:38 -06:00
Wliu
b6c804d637
Do not modify menus
2017-11-01 13:59:21 +01:00
Jason Rudolph
3d855b494d
Merge pull request #15981 from atom/decaf-tooltip-manager-spec
...
☠☕ ️ Decaffeinate `spec/tooltip-manager-spec.coffee`
2017-10-26 08:48:55 -04:00
Nathan Sobo
6e55b29331
Merge pull request #15993 from atom/dont-destroy-contained-folds
...
Preserve folds that are fully contained by the selection when changing selection ranges
2017-10-25 16:36:37 -06:00
Steven Hobson-Campbell
bbb331e1f7
Merge remote-tracking branch 'upstream/master' into tests
2017-10-25 14:14:12 -07:00
Nathan Sobo
d44d6abe53
Merge pull request #15990 from atom/non-asar-legacy-spec-project-path
...
Don't assign a default project path for package specs that
2017-10-25 12:57:16 -06:00
Nathan Sobo
00242541ae
Don't destroy folds that are completely contained within a selection
2017-10-25 12:25:04 -06:00
Nathan Sobo
364964ea0a
Always assign a project path outside of bundle for legacy package specs
...
This prevents package specs that don't have a fixtures directory from
attempting to read files out of a non-existent directory inside the ASAR
bundle, which causes ENOTDIR errors in superstring.
If the spec does not have a parent folder containing a fixtures
directory, we now set the default project path to `os.tmpdir()`.
2017-10-25 10:34:43 -06:00
Wliu
2bf9e4b0c7
Use scope names rather than names
...
Some languages are not guaranteed to have names
2017-10-25 17:36:21 +02:00
Max Brunsfeld
9a95372613
Merge pull request #15977 from atom/mb-use-language-modes
...
Move `toggleLineComments` method from TokenizedBuffer to TextEditor
2017-10-24 16:03:21 -07:00
Jason Rudolph
fc620b9e80
🎨 Move helper functions outside of describe
block
2017-10-24 09:06:50 -04:00
Jason Rudolph
aa69409b1b
🎨 Prefer arrow function syntax
2017-10-24 09:04:11 -04:00
Jason Rudolph
706f7e3d44
🎨 DS102 Remove unnecessary code created because of implicit returns
2017-10-24 08:58:59 -04:00
Jason Rudolph
76eb993e7e
🎨 DS101 Remove unnecessary use of Array.from
2017-10-24 08:56:20 -04:00
Jason Rudolph
90cfb69c7c
👕 Fix "'tooltipElement' is assigned a value but never used"
2017-10-24 08:53:24 -04:00
Jason Rudolph
f976c93d5a
👕 Fix "'disposable' is assigned a value but never used"
2017-10-24 08:51:40 -04:00
Jason Rudolph
7f75a46b97
👕 Fix "Return statement should not contain assignment"
2017-10-24 08:51:15 -04:00
Jason Rudolph
f771cf9d1a
☠ ☕ Decaffeinate spec/tooltip-manager-spec.coffee
...
Apply results of running:
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes spec/tooltip-manager-spec.coffee
$ standard --fix spec/tooltip-manager-spec.js
2017-10-24 08:47:44 -04:00
Jason Rudolph
622589f4f7
Merge pull request #15958 from atom/decaf-view-registry
...
☠☕ Decaffeinate `ViewRegistry`
2017-10-24 08:41:32 -04:00
Nathan Sobo
84f6f3e525
Merge pull request #15976 from atom/paste-without-reformatting
...
Add command to paste without reformatting
2017-10-23 20:21:38 -06:00
Max Brunsfeld
079f4d901c
Move all .toggleLineComments tests to text-editor-spec.js
2017-10-23 17:00:05 -07:00
Max Brunsfeld
311567ecec
Simplify .toggleLineComments method to avoid using oniguruma
2017-10-23 16:45:12 -07:00
leroix
c2662761f0
Merge pull request #15954 from atom/faster-overlay-resizing
...
Only update overlay instead of text editor when resize occurs
2017-10-23 17:05:57 -06:00
Nathan Sobo
6701644bbd
Respect format-preserving options in TextEditor.pasteText
2017-10-23 17:02:41 -06:00
Nathan Sobo
bbbf09ecf2
Add preserveTrailingLineIndentation option to Selection.insertText
...
We can use this to support a new command that preserves all formatting
when pasting.
2017-10-23 16:46:38 -06:00
Justin Ratner
ed94726fab
fix overlayComponent access syntax in test
2017-10-23 14:32:34 -06:00
Max Brunsfeld
49a2d0eeeb
Merge pull request #15974 from atom/mb-fix-fold-current-row-error
...
Fix exception when trying to fold non-foldable row
2017-10-23 11:12:52 -07:00
Max Brunsfeld
8d532e7780
Fix exception when trying to fold non-foldable row
2017-10-23 10:20:45 -07:00
Jason Rudolph
db960763cf
Merge pull request #15947 from atom/decaf-window-event-handler-spec
...
☠☕ ️ Decaffeinate `spec/window-event-handler-spec.coffee`
2017-10-23 08:39:31 -04:00
Jason Rudolph
01e7faa988
👔 Fix "Arrow function should not return assignment"
2017-10-21 10:10:06 -04:00
Jason Rudolph
33aea76058
👔 Fix "The object literal notation {} is preferrable"
2017-10-21 10:07:13 -04:00
Jason Rudolph
9a6f4b1647
👔 Fix "'model' is assigned a value but never used"
2017-10-21 10:05:57 -04:00
Jason Rudolph
c6d438c509
☠ ☕ Decaffeinate spec/view-registry-spec.coffee
2017-10-21 10:05:22 -04:00
Justin Ratner
089717cbd3
fix failing test
2017-10-20 15:46:27 -06:00
Wliu
1975e37e31
Merge pull request #13597 from Ingramz/rework-grammar-scores
...
Prioritize first line matches over bundled/non bundled cirteria in grammar scoring
2017-10-20 22:30:51 +02:00
Jason Rudolph
d23510fce9
☠ ☕ ️ Decaffeinate spec/window-event-handler-spec.coffee
2017-10-20 08:36:20 -04:00
Indrek Ardel
0f89211d55
Prioritize first line matches over bundled/non bundled cirteria
2017-10-20 13:34:15 +03:00
Michelle Tilley
158622ce48
Convert array of windows in AtomApplication to a WindowStack
2017-10-19 14:19:24 -07:00
Jason Rudolph
4db60e34b8
👔 Fix linter error: "Arrow function should not return assignment."
2017-10-18 20:13:55 -04:00
Jason Rudolph
49655a97c8
🎨
2017-10-18 20:10:24 -04:00
Jason Rudolph
6e78281a73
🎨 Prefer fat arrow function syntax
2017-10-18 19:54:51 -04:00
Jason Rudolph
498d7c90eb
Rewrite code to no longer use __guard__
2017-10-18 19:54:51 -04:00
Jason Rudolph
db115d3ab8
Remove unnecessary code created because of implicit returns
2017-10-18 19:54:51 -04:00
Jason Rudolph
61b228d8a0
Remove unnecessary use of Array.from
2017-10-18 19:54:51 -04:00
Jason Rudolph
c632e6ca58
☠ ☕ Decaffeinate spec/project-spec.coffee
...
Apply results of running:
```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes spec/project-spec.js
$ standard --fix spec/project-spec.js
```
2017-10-18 19:54:51 -04:00
Antonio Scandurra
280253fdfa
Merge pull request #15916 from atom/as-jr-stop-dragging-when-interacting-with-keyboard
...
Stop dragging only when user interacts with keyboard
2017-10-18 11:38:52 +02:00
Michelle Tilley
5e43084cd3
url -> URI
2017-10-17 15:23:10 -07:00
Michelle Tilley
5e96429c9e
Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch
2017-10-17 11:18:02 -07:00
Antonio Scandurra
65af9e953b
Stop dragging only when user interacts with keyboard
...
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.
On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217 , #15405 ).
This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.
One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.
Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
2017-10-17 18:50:20 +02:00
Antonio Scandurra
7853e3cd8c
Don't throw when destroying block decorations inside marker change event
2017-10-11 09:42:53 +02:00
Jason Rudolph
7463925e94
Merge pull request #15834 from atom/jr-decaf-gutter-container
...
Decaffeinate `GutterContainer`
2017-10-07 15:12:38 -04:00
Jason Rudolph
f79708a74a
Merge pull request #15823 from atom/jr-decaf-gutter
...
Decaffeinate `Gutter`
2017-10-06 09:35:11 -04:00
Jason Rudolph
d546037863
☠ ☕ Decaffeinate spec/gutter-container-spec.coffee
2017-10-06 09:33:43 -04:00
Antonio Scandurra
d83304cbdd
Exercise more features in the randomized test
...
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-10-05 19:41:28 +02:00
Jason Rudolph
51df9a308a
☠ ☕ Decaffeinate spec/gutter-spec.coffee
2017-10-05 11:06:42 -04:00
Antonio Scandurra
ec14125ecb
🎨
2017-10-05 13:51:26 +02:00
Antonio Scandurra
ae57cd268e
Delete unnecessary test code
2017-10-05 13:51:26 +02:00
Antonio Scandurra
1ca49d8f17
Move random-seed into script/package.json
...
...so that it doesn't get included in the final application bundle.
2017-10-05 13:51:26 +02:00
Antonio Scandurra
6e3b8cb9f8
Introduce randomized test for TextEditorComponent
2017-10-05 13:05:52 +02:00
Michelle Tilley
eb4357ce87
Add tests for packages with URI handlers
2017-10-03 13:20:48 -07:00
Michelle Tilley
4b67353f85
Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch
2017-10-03 13:16:02 -07:00
Max Brunsfeld
c46140946e
Merge pull request #15798 from atom/mb-prompt-to-save-in-conflict
...
Prompt to save when unloading if editor is in conflict
2017-10-03 12:36:43 -07:00
Nathan Sobo
f317a458ea
Merge pull request #15800 from atom/ns-fix-soft-wrap-rendering-bug
...
Fix rendering bug when folds cause the vertical scrollbar to disappear with soft wrapping enabled
2017-10-03 13:22:15 -06:00
Max Brunsfeld
4d057a16d6
Prompt to save when unloading if editor is in conflict
2017-10-03 11:09:33 -07:00
Max Brunsfeld
44d6868855
Preserve indentation when toggling comments on whitespace-only lines
2017-10-03 10:14:45 -07:00
Nathan Sobo
293b52d797
Fix rendering bug when folds hide the vertical scrollbar w/ soft wrap on
2017-10-03 11:09:44 -06:00
Max Brunsfeld
a778d5e09c
🎨
2017-09-28 17:09:55 -07:00
Max Brunsfeld
1d0dfe2213
Use async/await in package-manager-spec
2017-09-28 17:04:46 -07:00
Max Brunsfeld
a7db6ce7b1
Convert package-manager-spec to JS
2017-09-28 16:25:34 -07:00
Max Brunsfeld
969cb7a0f5
Merge pull request #15692 from UziTech/pane-onDidChangePath
...
Pane on did change path
2017-09-28 11:51:12 -07:00
Max Brunsfeld
6a86a1c7bf
Wait for repo to refresh in test
2017-09-27 14:19:05 -07:00