Commit Graph

2996 Commits

Author SHA1 Message Date
Michael Peyton Jones
388fd40ade
Purge GHC 8.8 (#3287)
We're also dropping support for this.
2022-10-18 22:12:53 +01:00
dependabot[bot]
dc62321779
Bump cachix/cachix-action from 10 to 11 (#3291)
Bumps [cachix/cachix-action](https://github.com/cachix/cachix-action) from 10 to 11.
- [Release notes](https://github.com/cachix/cachix-action/releases)
- [Commits](https://github.com/cachix/cachix-action/compare/v10...v11)

---
updated-dependencies:
- dependency-name: cachix/cachix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-17 14:28:27 +01:00
dependabot[bot]
f586f4d412
Bump cachix/install-nix-action from 17 to 18 (#3292)
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 17 to 18.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v17...v18)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-17 12:41:33 +01:00
Lei Zhu
8cef7a456a
Support ghc 9.4 for hls-class-plugin (#3258)
* Support ghc 9.4 for hls-class-plugin

* Update support table

* Update test description

* Update nix dependency
2022-10-16 11:56:43 -04:00
Andy
e36208bf72
Bump partial ghc support warning to 9.4 (#3286)
- 9.2 is now fully supported
- 9.4 is partially supported
2022-10-14 12:10:33 +00:00
Andy
5cdaa245dd
Improved message for missing command or plugin (#3285)
* No "PluginId" / "CommandId" prefix or quotes from show
* No line break, but comma separated
2022-10-12 16:12:47 +00:00
George Thomas
55456fb281
Register Fourmolu plugin properties (#3284)
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-10-12 12:15:05 +00:00
Andy
86e3fd6c65
Cleanup GHC macros (because min version is 8.8.4) (#3281)
* Drop min_version_ghc (8.8.4 is min supported)

* Drop conditional glasgow_haskell cpp

* Inline some imports (review feedback)

* Drop hie-compat 8.6 (review feedback)

* Dropping more ghc 8.6 related code and docs

* Eval: Include tests that were broken for 8.6
2022-10-11 22:35:18 +00:00
Pepe Iborra
9b491f7bbf
Drop compatibility with GHC 8.6.5 (#3101)
* Drop compatibility with GHC 8.6.5

* drop a few more bits

* fixup merge

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
2022-10-11 12:18:49 +00:00
Chrizzl
07f14e33b3
Remove unlawful Ord instance and replace it by a compare function (#3271) (#3279) 2022-10-11 09:54:10 +01:00
Chrizzl
e176eca897
Use an importance score to order the suggested import code action (#3234) (#3271)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-10-10 13:29:28 +00:00
Andy
21c8e9b83e
Hlint: A handful of fixes to hints (#3259)
* CI: rwe/actions-hlint-run v2

* fmt script: Fix missing directories

Otherwise will fail

* Hlint: Automatically fix warnings via apply-refact

* Hlint: Do not suggest fromMaybe

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-10-10 11:47:42 +00:00
Chrizzl
050497a19f
Exclude the implicit prelude import (#2798) (#3277) 2022-10-09 17:32:17 +00:00
Zdeno Osina
0eb79a4695
Fix action removes ticks from TemplateHaskellQuotes (#628) (#3260) 2022-10-09 13:38:27 +00:00
Akshay Mankar
4898f5b568
configuration-ghc-94.nix: Fix references to lsp and lsp-types source (#3265)
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-10-09 10:14:50 +01:00
Zdeno Osina
6d49b343ca
Fix typos in documentation (#3274) 2022-10-09 09:59:48 +01:00
Paweł Dybiec
595c527e43
Update plugin tutorial (#3266) 2022-10-08 12:45:45 +00:00
Kobayashi
d8e1e75241
Move new imports down the code action list (#3235)
* move new imports to the tail

* remove LANGUAGE CPP

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
2022-10-08 06:10:57 +00:00
Akshay Mankar
73b02ef3f7
Fix nix developement shell (#3257)
Upgrade a few packages which needed upgrade and avoid building hiedb in
nix as it has a dependency on a package in this repository (hie-compat).
2022-10-07 13:19:53 +00:00
Vilem
8fd2b89a01
Fix dead link to supported GHC versions (#3244)
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-10-06 09:36:25 +00:00
Michael Peyton Jones
b7e59d02e0
GCH -> GHC (#3252) 2022-10-06 08:45:37 +00:00
Andy
5bf8fe228b
Docs: Plugin Support hls-explicit-fixity-plugin (#3251) 2022-10-06 09:29:45 +01:00
citrusmunch
2e7d684983
update link to supported versions (#3242) 2022-10-05 16:07:18 +01:00
Michael Peyton Jones
f143cf1520
Add policy on plugin support tiers (#3189)
Following discussion in
https://github.com/haskell/haskell-language-server/discussions/3123.

This aims to make it more obvious what it means when we say we support a
version of GHC.
2022-10-03 10:00:06 +00:00
dependabot[bot]
b4abea79a0
Bump fkirc/skip-duplicate-actions from 5.1.0 to 5.2.0 (#3239)
Bumps [fkirc/skip-duplicate-actions](https://github.com/fkirc/skip-duplicate-actions) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/fkirc/skip-duplicate-actions/releases)
- [Commits](https://github.com/fkirc/skip-duplicate-actions/compare/v5.1.0...v5.2.0)

---
updated-dependencies:
- dependency-name: fkirc/skip-duplicate-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-03 09:07:41 +01:00
Javier Neira
c1d8f78160
Remove myself from codeowners (#3230)
Cause i am getting lot of notifications i dont have time to attend

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-09-29 15:59:20 +00:00
Kobayashi
011d110b4c
Fix error in code range (#3229)
* add test case

* handle error more properly

* add an error type

* fix tests

* log the bad dependency case
2022-09-29 04:54:06 +00:00
maralorn
f6dc2064d1
wrapper.in: Require runtime ghc-pkgs to be an abi compatible superset of bootpkgs (#3214)
This still makes sure that ghc has been compiled with the same core
libraries as hls while it allows runtime environments where other
packages have been added to the ghc-pkg database.

This commit also adds that file to the sdist, so that distro
packagers can use it.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-09-28 13:22:21 +00:00
Berk Özkütük
468db6f2aa
Use nixpkgs variants of Sphinx packages (#3227)
This commit replaces manually specified `myst-parser` and `sphinx_rtd_theme`
packages with their counterparts already packaged on nixpkgs. With this
change, `poetry2nix` is no more used, therefore that is removed as well.
2022-09-27 10:16:14 +01:00
Colten Webb
cdbef3e5cb
Feat: basic record dot completions (#3080)
* baseline for record completions

* address feedback

* gate ghc version

* add test

* refactor

* fix rope import

* fix plugins from rebase

* gate test by ghc version

* comments, fixes

* fix ghc90 test
2022-09-26 16:30:29 +01:00
hololeap
e09c00588b
hls-hlint-plugin: Update README.md (#3216)
Remove warning about hlint restrictions, as #1340 has been merged.

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-09-26 13:37:47 +01:00
dependabot[bot]
30b2a4716e
Bump fkirc/skip-duplicate-actions from 4.0.0 to 5.1.0 (#3226)
Bumps [fkirc/skip-duplicate-actions](https://github.com/fkirc/skip-duplicate-actions) from 4.0.0 to 5.1.0.
- [Release notes](https://github.com/fkirc/skip-duplicate-actions/releases)
- [Commits](https://github.com/fkirc/skip-duplicate-actions/compare/v4.0.0...v5.1.0)

---
updated-dependencies:
- dependency-name: fkirc/skip-duplicate-actions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-26 09:13:27 +01:00
Kobayashi
217573f4a1
Improve haddock comments (#3207)
* remove 'buildable: False' in cabal

* remove constraint on ghc-exactprint

* wip

* revert HaddockComments.hs

* generate haddock comments for constructors

* fix tests

* restore constraints

* make it compatible with ghc 9.0

* add more tests

* add comments & fix dp calculation for inline case

* add kokobd to codeowners of haddock-comments plugin

* fix a comment

* rephrase some comments to make them clearer

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-09-26 00:05:19 +00:00
fendor
6f9b435331
Sort vscode extension schema json by keys (#3203)
Makes it easier to copy and paste configurations into VSCode and
reviewing what options have been added and removed.

Remove code-duplication, namely ghcide exe loses some capabilities, as
it is destined to be removed sooner or later.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-09-25 15:34:55 +00:00
hololeap
c422cf373a
Add source-repository to all cabal files (#3219)
Add a source-repository stanza to any .cabal files in the project that
are missing it.

This metadata can be useful for package maintainers.

See: https://cabal.readthedocs.io/en/stable/cabal-package.html#source-repositories

Signed-off-by: hololeap <hololeap@users.noreply.github.com>

Signed-off-by: hololeap <hololeap@users.noreply.github.com>
2022-09-24 02:50:25 +00:00
Pepe Iborra
fd1a7d1923
Add diagnostics to Stan descriptor (#3213) 2022-09-23 06:01:22 +00:00
Berk Özkütük
b289e48064
Add a note regarding the stack requirement in wrapper tests (#3212) 2022-09-22 12:03:33 +00:00
Pepe Iborra
dca5cc36c7
Log plugin name and attribute errors to plugins (#3194)
* Log plugin name

* redundant import

* Attribute response error logs to plugins

* remove redundant plugin names from error messages

* improve pretty printing

* Avoid show

* simplify test messages

* Fix
2022-09-21 17:36:19 +00:00
Lei Zhu
b547d4e9ac
Fix broken call-hierarchy-plugin-tests for type signatures (#3188)
* Fix broken tests for signatures

* Remove unused Maybe

* Refactir prepare

* Refactor incoming and outgoing calls

* Fix doc format

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-09-21 14:43:53 +00:00
Aarush Bhat
42bcf9229a
Feat: Folding Ranges (#3058)
* save some progress: add basic starter code for folding ranges

* save some progress: add function to traverse through coderange and form folding ranges

* save some progress: add parsing of folding ranges

* fix: maybe issue with foldingRanges

* add: generate folding ranges from coderange

* add: plugin request method instance for folding ranges

* ref: alter function and var names

* post review: cleanup crk to frk & fix typo

* fix: find folding ranges function

* format: run formatter and add comments

* fix: return all response results of folding range request

* Revert "format: run formatter and add comments"

This reverts commit e6a2b5ca3e.

* add: removed comments after revert

* fix: formatting

* docs: add folding range to features section and cabal file

* refactor: use destructuring for createFoldingRange function and use characters

* test: add basic unit test for findFoldingRanges function

* test: add tests for children and code kind

* test: add more test cases

* test: add test for createFoldingRange

* test: add integration test for folding ranges

* fix: duplicate start line foldingranges and remove single line
foldingranges

* refactor: duplicate folding range functionality

* fix: formatting in code range plugin

* added more descriptive comments and encorporate code review suggestions

* revert: automatic formatting for selection range test case file

* fix: ignoring children if root fails to provide folding ranges

* remove: redundant match on crkToFrk

* revert: filtering same line foldings and multiple foldings on the same line as it can be handled by clients

* revert: formatting change to selection range test file

* fix: entire file folding because of root node

Co-authored-by: Kobayashi <contact@zelinf.net>
2022-09-21 12:59:57 +01:00
Andy
bd1d0a1675
Stylish Haskell: CPP parse issues (#3199)
* Stylish Haskell: Parse issues

* CPP language extension
* Manually fix some files with duplication

* Pre-commit: Fix ignored files

It looks like `ExactPrint` was ignored before, but since absolute paths
are used and weren't adapted it wasn't ignored afterwards.
2022-09-19 20:31:37 +00:00
maralorn
00469199cf
docs/supported-versions: Fix typo and make brittany versions more precise (#3201) 2022-09-19 16:45:35 +00:00
dependabot[bot]
0d21448276
Bump technote-space/get-diff-action from 4.0.1 to 6.1.0 (#3198)
Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 4.0.1 to 6.1.0.
- [Release notes](https://github.com/technote-space/get-diff-action/releases)
- [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc)
- [Commits](https://github.com/technote-space/get-diff-action/compare/v4.0.1...v6.1.0)

---
updated-dependencies:
- dependency-name: technote-space/get-diff-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-19 07:35:49 +00:00
Nick Suchecki
ff4f29f859
Only run the pre-commit hook on changed files (#3145)
* Only run the pre-commit hook on changed files

* Let's change a haskell file

* Didn't use the PATTERN field correctly

* Move pre-commit block before building stylish-haskell

* Try to evaluate GIT_DIFF value to pass to pre-commit

* Try to evaluate GIT_DIFF value to pass to pre-commit

* Move pre-commit action back to original spot

* Introduce bad formatting in a file

* Conditionally run the pre-commit job only when there are haskell source
changes

* Restore haskell files we used for testing

* workflow fixes

* Try changing haskell source files with new workflow structure

* Revert all changes to files during testing

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
2022-09-18 19:21:22 +00:00
Andy
362ca34488
Refactor plugin: Prefer code action (#3167)
`isPreferred` can influence the client side order of code actions. The
idea is that an unused import is likely to be removed and less likely
the warning will be disabled. Therefore actions to remove a single or
all redundant imports should be preferred, so that the client can
prioritize them higher.

Followup of
<https://github.com/haskell/haskell-language-server/pull/3018>
2022-09-18 16:58:11 +00:00
Andy
b378de2d42
Solve formatting issues (stylish-haskell, pre-commit CI) (#3171)
* Solve formatting issues

* stylish-haskell parse errors solved (partially)

* Env: Changing order (import)
* Plugins: Dangling `$`

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
2022-09-18 08:41:14 +00:00
Pepe Iborra
a13e1b3c8d
Clean up heapsize bits (#3168) 2022-09-18 09:03:46 +02:00
Andy
aee737237c
Configuration: more advanced Vim / Coc example (#3181)
Adding an example with settings

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
2022-09-17 17:26:18 +00:00
Michael Peyton Jones
41c978dd66
Update supported GHC versions doc (#3186)
Fixes #3172.
2022-09-17 15:10:39 +00:00
Andy
d7bdd0c6cd
Docs: Fix checkParents documentation (#3184)
* Check on close modes were removed
* Moving docs to configuration and away from ghcide README
2022-09-17 12:00:32 +00:00