jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2025-01-07 02:09:35 +03:00
Code Issues Packages Projects Releases Wiki Activity
2,992 Commits 54 Branches 48 Tags 7.5 MiB
06237c7fc9
Commit Graph

619 Commits

Author SHA1 Message Date
Jeroen Engels
f27b42d4f3 Remove unnecessary operations on errors 2022-10-29 17:58:24 +02:00
Jeroen Engels
4d3f2bc078 Backport elm-review-debug 2022-10-15 11:52:21 +02:00
Jeroen Engels
65c023481a Add test rule for extracting data 2022-10-12 16:39:00 +02:00
Jeroen Engels
363b48c7e8 Add expectations for the data extract in the test module 2022-10-12 16:39:00 +02:00
Jeroen Engels
64fd5fd49b Bump elm-test to v2 2022-10-12 16:21:44 +02:00
Jeroen Engels
2fb55010fc Backport rules from elm-review-common 2022-09-19 12:01:49 +02:00
Jeroen Engels
4dd3bb5dff Backport rules from elm-review-unused 2022-09-19 11:54:35 +02:00
Jeroen Engels
6e883bca87 Filter ignored files and set rule name before caching errors 2022-09-18 00:24:24 +02:00
Jeroen Engels
e726935135 Speed up computeModules 2022-09-17 21:46:20 +02:00
Jeroen Engels
c931c47c81 Speed up runReview 2022-09-17 21:34:48 +02:00
Jeroen Engels
2332828230 Speed up errorsFromCache 2022-09-17 21:34:48 +02:00
Jeroen Engels
913f11f5e4 Add tests for ignored files 2022-09-17 21:34:48 +02:00
Jeroen Engels
a37d5afedc Backport rules from elm-review-forbidden-words 2022-09-01 18:00:56 +02:00
Jeroen Engels
f9e1d8aef8 Backport rules from Simplify 2022-09-01 16:22:25 +02:00
Jeroen Engels
3ef7727ae7 Backport rules from elm-review-documentation 2022-08-24 18:31:28 +02:00
Jeroen Engels
faef56d338 Backport rules from elm-review-unused 2022-08-24 18:10:58 +02:00
Jeroen Engels
b4f11c5ddf
Fix ModuleNameLookupTable resolving to indirect dependencies (#135) 2022-08-23 17:09:29 +02:00
Jeroen Engels
2a211e9d22 Use direct dependencies visitor in test rules 2022-08-22 21:49:08 +02:00
Jeroen Engels
d746a21c9a Add withDirectDependencies visitors 2022-08-22 21:49:08 +02:00
Jeroen Engels
67c9eecd29 Simplify NoUnused.Exports 2022-08-08 13:45:43 +02:00
Jeroen Engels
d0f804fbaa Use withFullAst in NoUnused.Exports 2022-08-08 10:39:50 +02:00
Jeroen Engels
fc8d1aac9f Add withModuleDocumentation 2022-08-08 10:39:50 +02:00
Jeroen Engels
8b6d539239 Add Rule.withFullAst 2022-08-08 10:39:50 +02:00
Jeroen Engels
350300e0c9
Add Rule.withModuleDocumentationVisitor (#132) 2022-08-07 13:36:28 +02:00
ScribblyBirb
9bdc37b98c
Fix flipped error message in global error details test failure (#130) 
Error message for `unexpectedGlobalErrorDetails` and
`unexpectedConfigurationErrorDetails` had their expected and actual
details flipped.
 2022-07-17 09:39:30 +02:00
Jeroen Engels
187e8a34be Backport NoDeprecated 2022-06-29 23:42:52 +02:00
Jeroen Engels
ab41f236bd Fix typo in test failure message 2022-06-22 22:37:48 +02:00
Jeroen Engels
e290a15b3a Change the wording for emptyDetails 2022-06-22 22:37:48 +02:00
Jeroen Engels
d90bfb46cb Add test for unexpectedConfigurationErrorDetails 2022-06-22 22:37:48 +02:00
Jeroen Engels
fae198f186 Make test failure message's order consistent 2022-06-22 22:37:48 +02:00
Jeroen Engels
70d430ae5c Use qualified Rule.Error in examples 2022-06-21 17:43:44 +02:00
Jeroen Engels
ca3c4e7cd7 Change test title 2022-06-20 19:25:41 +02:00
Jeroen Engels
f79e970019 Change default file paths for files in tests 2022-06-20 19:25:41 +02:00
Jeroen Engels
3ff9098d30 Add fullModuleNameAt and fullModuleNameFor in ModuleNameLookupTable 2022-05-01 20:26:20 +02:00
Jeroen Engels
dddba5c1cf Stop using Rule.withMetadata in plugin rules 2022-04-28 13:25:24 +02:00
Jeroen Engels
0fa1005f4d Use new context creator functions 2022-04-28 13:25:24 +02:00
Jeroen Engels
d17d995f0e Add Rule.withModuleName 2022-04-28 11:51:14 +02:00
Jeroen Engels
319ecb29a6 Add Rule.withFilePath 2022-04-28 11:41:01 +02:00
Jeroen Engels
8ab6272a39 Backport rules from other packages 2022-04-22 22:04:13 +02:00
Jie
2bc6c2ec33
Add Rule.filterErrorsForFiles (#115) 2022-02-04 17:16:08 +01:00
Jie
bbc6ce4365
Small typos (#116) 
* tat -> that

* yoy -> you
 2022-01-19 14:28:42 +01:00
SiriusStarr
a4816ddc11 Modify test for declaration list to check order 2022-01-05 20:46:47 +01:00
Jeroen Engels
0deab17a61 Simplify WithCommentsVisitorTest 2022-01-05 16:56:16 +01:00
SiriusStarr
3068ead8f4 Add failing test for withCommentsVisitor 
Ensure that only non-parsed doc comments are passed and they are done so
in source order.
 2022-01-05 16:55:35 +01:00
SiriusStarr
f643cae09e Add missing test for comment visitor order 
Previously, the order of comment visitors was untested, despite being
claimed to occur at a specific point in the documentation (before import
visitor).
 2022-01-05 16:46:42 +01:00
Jeroen Engels
b71984aebb Backport rules from elm-review-unused 2021-10-24 00:38:58 +02:00
Jeroen Engels
28a3973272 Backport rules from elm-review-common 2021-10-17 10:00:47 +02:00
SiriusStarr
2a8dbaf2a1
Add ModuleNameLookupTable support for operators (#106) 2021-10-03 11:03:00 +02:00
Jeroen Engels
34798e3f49 Backport elm-review-documentation 2021-10-02 10:32:41 +02:00
Jeroen Engels
7e6cd42469 Backport rules 2021-08-19 20:57:33 +02:00
Jeroen Engels
e60ff158a7 Backport rules from elm-review-code-style 2021-08-19 20:55:58 +02:00
Jeroen Engels
9daae2933d Backport rules from elm-review-common 2021-08-19 20:50:50 +02:00
Jeroen Engels
1c99a7e99b Make variable name more explicit 2021-07-30 18:33:53 +02:00
Jeroen Engels
7489b6b458
Add withSourceCodeExtractor (#100) 2021-05-29 00:00:12 +02:00
Jeroen Engels
feb67febe1 Backport rules from elm-review-code-style 2021-05-26 22:29:13 +02:00
Jeroen Engels
dda4c684b1 Simplify code 2021-04-24 14:33:20 +02:00
Jeroen Engels
05d2622923 Backport rules from elm-review-unused 2021-04-17 21:18:43 +02:00
Jeroen Engels
7c8701aec4 Backport rules from elm-review-debug 2021-04-06 17:33:00 +02:00
Jeroen Engels
a26dd41382 Backport rules from elm-review-common 2021-04-06 17:32:30 +02:00
Jeroen Engels
9992afbff8 Backport rules from elm-review-unused 2021-04-06 17:19:13 +02:00
Jeroen Engels
0578e9ed54 Make build target return a Result 2021-03-27 10:16:18 +01:00
Jeroen Engels
ed57af4909 Reverse positions 2021-03-27 10:12:25 +01:00
Jeroen Engels
38cf239e4e Use enter visitor 2021-03-27 10:11:07 +01:00
Jeroen Engels
cee660cd0a Stop using tests/Dependencies/ElmCore.elm and remove it 2021-03-14 09:12:41 +01:00
Jeroen Engels
25cad184d0 Make Review.Test.expectConfigurationError work without run* functions 2021-03-10 17:09:16 +01:00
Jeroen Engels
b2f04d3614 Compute whether the unsafeFunction is a valid function name 2021-03-10 17:09:16 +01:00
Jeroen Engels
efe502f52f Add details to the test expectation 2021-03-10 17:09:16 +01:00
Jeroen Engels
3e43ba80b3 Base configuration error off of buildTarget 2021-03-10 17:09:16 +01:00
Jeroen Engels
31a4dc53e0 Trigger configuration error in NoUnsafeRegexFromLiteral 2021-03-10 17:09:16 +01:00
Jeroen Engels
fdc25443d1 Add configuration error 2021-03-10 17:09:16 +01:00
Jeroen Engels
7a2978925f Make emptyDetails take a String 2021-03-10 17:02:21 +01:00
Jeroen Engels
49025a5855 Fail when expected error could not be found 2021-03-10 17:02:21 +01:00
Jeroen Engels
253b04187e Add unexpectedGlobalErrorDetails 2021-03-10 17:02:21 +01:00
Jeroen Engels
f1f97de257 Change error message for unexpectedDetails 2021-03-10 17:02:21 +01:00
Jeroen Engels
5e112638f7 Change test breakage 2021-03-10 17:02:21 +01:00
Jeroen Engels
279ac055bb Remove handling of global error module name 2021-03-10 17:02:21 +01:00
Jeroen Engels
bbc4697d9f Duplicate 2021-03-10 17:02:21 +01:00
Jeroen Engels
0dd50b51d9 break test 2021-03-10 17:02:21 +01:00
Jeroen Engels
0c5feb427c Start working on expectGlobalErrors 2021-03-10 17:02:21 +01:00
Jeroen Engels
cb84596b08 Handle global errors differently 2021-03-10 17:02:21 +01:00
Jeroen Engels
f46f3216bb Make a specific error for too many global errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
cc17889499 Make a specific error for unexpected global errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
4cb8d74815 Change the error message for global errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
1789110c4a Use globalerror 2021-03-10 17:02:21 +01:00
Jeroen Engels
3d2b7234f9 Fix test 2021-03-10 17:02:21 +01:00
Jeroen Engels
22f68ab542 Add Review.Test.expectGlobalErrors function 2021-03-10 17:02:21 +01:00
Jeroen Engels
6345bc8a90 Add annotations 2021-03-10 17:02:21 +01:00
Jeroen Engels
0d7eb30f4e Remove code related to getting the elm.json key 2021-03-10 17:02:21 +01:00
Jeroen Engels
362a192665 Print target function name 2021-03-10 17:02:21 +01:00
Jeroen Engels
2da8367965 NoUnsafeRegexFromLiteral: Report as global error 2021-03-10 17:02:21 +01:00
Jeroen Engels
6bf6d41c55 Backport NoUnsafeRegexFromLiteral rule 2021-02-28 18:51:45 +01:00
Jeroen Engels
a4bb1719b5 Backport rules from elm-review-code-style 2021-02-10 17:15:09 +01:00
Jeroen Engels
584f0bef8a Adapt tests to elm-syntax fix 2021-02-02 16:03:05 +01:00
Jeroen Engels
4669fe3960 Backport elm-review-unused 2021-01-24 16:46:42 +01:00
Jeroen Engels
63819d3fb7 Backport elm-review-debug 2021-01-24 16:43:58 +01:00
Jeroen Engels
fa8bc02068 Backport rules from elm-review-common 2021-01-19 21:45:35 +01:00
Jeroen Engels
cb604c782f Backport unused and test-values 2020-12-23 19:12:04 +01:00
Jeroen Engels
2a4c93a0b4 Remove unused imports 2020-12-21 21:45:55 +01:00
Jeroen Engels
f044f9cd1d ModuleNameLookupTable: Add test to make sure that aliasing in patterns works 2020-12-06 14:30:39 +01:00
Jeroen Engels
c6ca7ec9fe Backport elm-review-unused 2020-12-05 12:40:40 +01:00
Jeroen Engels
13371a1af9 Backport rules from elm-review-noop 2020-11-18 10:16:23 +01:00
Jeroen Engels
ed1f40bbc3 Fix ModuleNameLookupTable not registering aliases from the prelude 2020-11-18 10:07:16 +01:00
Jeroen Engels
66f5375eaa ModuleNameLookupTableTest: Add tests for function declarations handling 2020-09-23 10:38:39 +02:00
Jeroen Engels
82037d4e5b ModuleNameLookupTableTest: Add signature texts 2020-09-23 10:30:47 +02:00
Jeroen Engels
efebce84d1 ModuleNameLookupTableTest: Refactor declaration visitor 2020-09-23 10:27:39 +02:00
Jeroen Engels
ccfcc99468 ModuleNameLookupTableTest: Add declaration visitor 2020-09-23 10:25:40 +02:00
Jeroen Engels
97c0e4abe9 Add test for handling pattern aliases 2020-09-23 10:21:35 +02:00
Jeroen Engels
c2488a06b0 Add failing test case for ModuleNameLookupTableTest 2020-09-23 10:12:19 +02:00
Jeroen Engels
b1b96c6dcf Backport rules from other projects 2020-09-23 08:11:51 +02:00
Jeroen Engels
80e4d87436 Use helper in declaration visitor 2020-09-22 19:08:17 +02:00
Jeroen Engels
75e535ce2a Use helper in expression visitor 2020-09-22 19:06:45 +02:00
Jeroen Engels
4ad35edde3 Add helper for showing the real name 2020-09-22 19:03:43 +02:00
Jeroen Engels
01e2f66fc7 Rename test module 2020-09-22 19:01:02 +02:00
Jeroen Engels
2208b410a0 Change test suite title 2020-09-22 19:00:15 +02:00
Jeroen Engels
e4acd4de29 Move code from ModuleNameForValueTest into ModuleNameForTypeTest 2020-09-22 18:59:34 +02:00
Jeroen Engels
bb0955c07b ModuleNameType: Creator rule dynamicaly 2020-09-22 18:56:30 +02:00
Jeroen Engels
e925d0a25a Fix files not being evaluated when they're ignored in project rules without a folder 2020-09-09 18:50:42 +02:00
Jeroen Engels
3087e757a8 Fix module name lookup table not knowing about patterns inside let functions destructuring 2020-09-08 10:06:28 +02:00
Jeroen Engels
0ff71b2c84 Remove unused code 2020-08-26 19:01:47 +02:00
Jeroen Engels
7c0d7e6fad Support record update functions for module name lookup table 2020-08-25 15:28:56 +02:00
Jeroen Engels
7455bca8a8 Use lookup table in ScopeExample 2020-08-22 10:23:25 +02:00
Jeroen Engels
9c40b95394 Add ScopeExample 2020-08-22 10:21:53 +02:00
Jeroen Engels
219bb11ff6 Use lookup table in ModuleNameForValueTest 2020-08-22 10:02:31 +02:00
Jeroen Engels
e550dce72d Use lookup table in ModuleNameForTypeTest 2020-08-22 09:54:20 +02:00
Jeroen Engels
31eef5486b Use lookup table in NoUnused.CustomTypeConstructors 2020-08-22 09:43:30 +02:00
Jeroen Engels
808baa1a22 Use lookup table in NoUnused.Exports 2020-08-22 08:50:39 +02:00
Jeroen Engels
7064268dc0 Use lookup table in NoUMissingSubscriptionsCall 2020-08-21 23:29:54 +02:00
Jeroen Engels
3e85e3709a Add elements in the lookup table 2020-08-21 20:53:33 +02:00
Jeroen Engels
08a3cbf7a7 Pass in module name lookup table to rules 2020-08-21 18:53:22 +02:00
Jeroen Engels
95b4e12b76 Use the lookup tables collected during the pre-run 2020-08-21 09:27:01 +02:00
Jeroen Engels
c4f1a268d6 TMP Only run a single test 2020-08-20 23:00:21 +02:00
Jeroen Engels
2b12cebd9c Use lookup table 2020-08-19 23:43:02 +02:00
Jeroen Engels
556a4b24bc Move again 2020-08-19 23:26:48 +02:00
Jeroen Engels
494d376ba6 Add ModuleNameLookupTable 2020-08-19 23:16:20 +02:00
Jeroen Engels
f32dc336af Add new Scope type 2020-08-19 23:01:43 +02:00
Jeroen Engels
df8fef43e9 Remove unused variable in NoUnapprovedLicense 2020-08-11 17:20:52 +02:00
Jeroen Engels
449b21addd Backport rules from other packages 2020-08-09 18:56:12 +02:00
Jeroen Engels
747dfabb3f Rename and document new functions 2020-07-02 07:41:19 +02:00
Jeroen Engels
aa72525032 Remove unused function 2020-06-28 13:44:52 +02:00
Jeroen Engels
260f34d743 Add a new function to initialize a module rule's context using a context creator + isInSourceDirectories metadata 2020-06-28 12:21:13 +02:00
Jeroen Engels
619850016a Add a way to get the module context using a module context creator 2020-06-28 10:00:43 +02:00
Jeroen Engels
4c43013fb8 Remove Rule3 2020-06-28 08:01:44 +02:00
Jeroen Engels
d2220e652b Use Rule instead of Rule3 2020-06-28 08:01:44 +02:00
Jeroen Engels
0688386fb8 Remove unused code 2020-06-26 19:39:07 +02:00
Jeroen Engels
7bd35b1941 Add project visitors to module visitors 2020-06-26 00:08:31 +02:00
Jeroen Engels
1d5ca98a61 Make visitor order test more robust 2020-06-25 23:09:09 +02:00
Jeroen Engels
c8445f7bf6 Rename all _New functions 2020-06-25 22:57:31 +02:00
Jeroen Engels
8216097025 Rename ModuleVisitor into ModuleRuleSchema, until the next breaking change 2020-06-25 22:52:11 +02:00
Jeroen Engels
94b0ab6a79 Turn module visitors into project rules 2020-06-25 22:49:44 +02:00
Jeroen Engels
b66816b589 Add module visitors to project rules 2020-06-25 19:23:09 +02:00
Jeroen Engels
dc131e8265 Use new module rules in tests 2020-06-25 19:23:09 +02:00
Jeroen Engels
5a2e85ecbf Create working project rule without module visitors 2020-06-25 19:23:09 +02:00
Jeroen Engels
c9e8f9680d Backport changes from review dependencies 2020-06-20 20:09:03 +02:00
Jeroen Engels
97179db534 Remove unused variables in NoLeftPizza 2020-06-20 18:21:58 +02:00
Jeroen Engels
b98f83d5f9 Backport changes from elm-review-noleftpizza 2020-06-19 18:44:03 +02:00
Jeroen Engels
2082f1fd34 Use withExpressionEnterVisitor in tests and examples 2020-06-19 17:57:27 +02:00
Jeroen Engels
748583e778 Deprecate Direction 2020-06-19 15:35:11 +02:00
Jeroen Engels
5e2b633c54 Fix inversion of result and expected fixed source code in whitespace failure message 2020-06-19 12:36:12 +02:00
Jeroen Engels
cfd7a9157e Rename enter and exit visitors 2020-06-16 22:03:18 +02:00
Jeroen Engels
767a7ba321 Use onEnter variants on test rules 2020-06-16 00:00:41 +02:00
Jeroen Engels
210dbea5e1 Enable NoUnused.Parameters 2020-06-14 16:44:44 +02:00
Jeroen Engels
acc00dfc3f Backport changes from review-unused and elm-review-scope 2020-06-14 16:44:44 +02:00
Jeroen Engels
be43b18a2f Make every test failure title red and bold 2020-06-03 19:16:42 +02:00
Jeroen Engels
932c788b9f Backport work from review packages 2020-06-03 18:23:19 +02:00
Jeroen Engels
46f94c220d Fix tests: fixed code with only two lines was incorrectly extracted 2020-06-02 18:04:08 +02:00
Jeroen Engels
70bfc6f0bd Rename NoInvalidLicense to NoUnapprovedLicense 2020-06-01 09:02:33 +02:00
Jeroen Engels
ca98c71e43 Make "Rule reported less errors than expected" error more informative 2020-05-19 19:41:11 +02:00
Jeroen Engels
c76d4d972f Make expected errors order-agnostic 
Fixes #12
 2020-05-17 17:08:27 +02:00
Jeroen Engels
ee8f294c18 Backport scope v0.2.0 2020-05-16 22:44:11 +02:00
Jeroen Engels
f1e3e725a8 Backport work from review-unused 2020-05-14 21:24:29 +02:00
Jeroen Engels
7d2a08d335 Backport Scope 2020-05-14 21:24:29 +02:00
Jeroen Engels
d0bd0579f3 Fix Review.Test not working correctly with multilines 2020-05-14 21:24:29 +02:00
Jeroen Engels
d2c37dd489 Fix typo in test failure messages 2020-05-14 20:45:16 +02:00
Jeroen Engels
06564b9cc1 Rename ErrorMessage to FailureMessage 2020-05-14 20:45:16 +02:00
Jeroen Engels
bd4377f106 Fix files not being ignored correctly in Windows 2020-04-29 19:32:06 +02:00
Jeroen Engels
d0b9cb16f7 Remove Review.Scope 2020-04-21 23:02:26 +02:00
Jeroen Engels
33c85462ed Backport work from review packages and elm-review-scope 2020-04-21 23:01:47 +02:00
Jeroen Engels
418a50e183 Backport work from review packages 2020-04-20 23:11:53 +02:00
Jeroen Engels
2d42e89092 Backport work from review packages 2020-04-08 18:36:56 +02:00
Jeroen Engels
1fbf67bddb Backport work from review-common 2020-04-08 00:19:25 +02:00
Jeroen Engels
ddf76dcba9 Backport work from review packages 2020-04-07 23:25:35 +02:00
Jeroen Engels
1d91332a68 Remove duplicate information in NoInvalidLicense 2020-04-06 19:13:13 +02:00
Jeroen Engels
2070a15ada Backport work from review-simplification 2020-04-06 17:18:56 +02:00
Jeroen Engels
4f2500c9c8 Backport work from review-simplification 2020-04-05 09:57:34 +02:00
Jeroen Engels
236da80392 Backport work from NoDebug 2020-04-05 09:47:59 +02:00
Jeroen Engels
9ce54258a6 Remove references to withFixes 2020-04-05 09:25:17 +02:00
Jeroen Engels
1f38de974a Backport work from NoUnused 2020-04-04 15:56:40 +02:00
Jeroen Engels
f96b38160b Improve how fixes are applied 2020-04-04 14:29:40 +02:00
Jeroen Engels
7716c9d2c9 Remove Rule.withFixes function 2020-04-04 12:58:26 +02:00
Jeroen Engels
fdca981cc5 Add Documentation rules like they are in jfmengels/review-documentation 2020-04-04 12:35:29 +02:00
Jeroen Engels
b478d2d374 Add autofix for Documentation.ReadmeLinksPointToCurrentVersion 2020-04-04 12:35:29 +02:00
Jeroen Engels
a932f65fe9 Add Documentation.ReadmeLinksPointToCurrentVersion rule 2020-04-04 12:35:29 +02:00
Jeroen Engels
1143afeb31 Re-allow README to be automatically fixed 2020-04-04 12:35:29 +02:00
Jeroen Engels
8637b6050e Move misc rules into a separate folder 2020-04-03 23:00:51 +02:00
Jeroen Engels
30eabfde39 Reorganize test files for the core internals 2020-04-03 16:19:24 +02:00
Jeroen Engels
ec4044826b Re-organize test rules 2020-04-03 16:19:24 +02:00
Jeroen Engels
19f35f835f Move test rules into tests/ 2020-04-03 16:19:24 +02:00
Jeroen Engels
60106d7958 Add NoUnused rules like they are in jfmengels/review-unused 2020-04-03 16:19:24 +02:00
Jeroen Engels
02d7665e91 Add NoDebug rules like they are in jfmengels/review-debug 2020-04-03 16:19:24 +02:00
Jeroen Engels
61aaf0f873 Give less useless details in NoUnused rules 2020-04-01 22:40:23 +02:00
Jeroen Engels
0f25a734e5 Change the order of Scope.realModuleName arguments 2020-04-01 20:13:45 +02:00
Jeroen Engels
402eb6f813 Update NoUnusedVariable 2020-04-01 20:13:45 +02:00
Jeroen Engels
143ecb9618 Rename realFunctionOrType by realModuleName 2020-04-01 20:13:45 +02:00
Jeroen Engels
9328872aa6 Rename Scope2 to Review.Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
baafd04810 Fix prelude loading in Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
69c6f4e515 Use Scope2 instead of Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
ab360b6db1 Add phantom type variable to Error in documentation examples 2020-04-01 20:13:45 +02:00
Jeroen Engels
5dec76b06c Prevent use of error in project visitors 2020-04-01 20:13:45 +02:00
Jeroen Engels
31cd0c6691 Add phantom type variable to Error in other files than Review.Rule 2020-04-01 20:13:45 +02:00
Jeroen Engels
1bd923cd5f Fix wrong error message. Thanks Anton Komissarov! 2020-03-23 20:42:29 +01:00
Jeroen Engels
023bbd60b5 Rename Project.withReadme to Project.addReadme 2020-03-20 19:06:09 +01:00
Jeroen Engels
6f73e42b9a Rename Project.withDependency and Project.withElmJson to Project.add* 2020-03-19 23:50:41 +01:00
Jeroen Engels
160cea7323 Remove module visitors for rules that didn't need them 2020-03-19 19:35:45 +01:00
Jeroen Engels
3077047e63 Make Scope add all visitors at once 2020-03-19 19:28:01 +01:00
Jeroen Engels
f076643150 Remove context and visitor argument for newProjectRuleSchema 2020-03-19 19:21:49 +01:00
Jeroen Engels
ce7c6b7021 Move initial project context to an argument of Rule.newProjectRuleSchema 2020-03-19 19:03:12 +01:00
Jeroen Engels
3b2449af08 Allow to expect for README errors in tests 2020-03-18 23:25:56 +01:00
Jeroen Engels
8273322832 Allow elm.json visitors to report errors in project rules 2020-03-18 23:08:06 +01:00
Jeroen Engels
7c76d8947a Add README support to Review.Project 2020-03-18 21:01:12 +01:00
Jeroen Engels
4263f35db9 Add dummy rule that will look at the README 2020-03-18 20:32:31 +01:00
Jeroen Engels
c619e2c484 Improve the range for NoTodoComment 2020-03-18 17:35:11 +01:00
Jeroen Engels
8013011d1a Handle phantom types outside of the module 2020-03-15 22:53:45 +01:00
Jeroen Engels
68eda525b5 Handle imports from other modules 2020-03-15 14:12:22 +01:00
Jeroen Engels
abcd73f0e4 Mark custom types... 2020-03-14 21:13:23 +01:00
Jeroen Engels
36b71557da WIP Mark custom type constructors from other modules as used. 2020-03-12 19:19:06 +01:00
Jeroen Engels
ad2f929d7e Report custom type constructors that are exposed 2020-03-12 17:46:51 +01:00
Jeroen Engels
36a3478828 NoUnused.CustomTypeConstructors: Report unused exposed type constructors 2020-03-12 17:23:00 +01:00
Jeroen Engels
4117baf838 Rename NoUnused.CustomTypeConstructors temporarily 2020-03-12 17:05:36 +01:00
Jeroen Engels
ce1c059d4c NoUnused.CustomTypeConstructors: Transform into a project rule 2020-03-12 16:59:14 +01:00
Jeroen Engels
b2fd92f529 NoUnused.CustomTypeConstructors: Prepare looking at other modules 2020-03-12 16:50:03 +01:00
Jeroen Engels
ce4febc1ac Support phantom types in NoUnused.CustomTypeConstructors 2020-03-11 17:51:09 +01:00
Jeroen Engels
c67aa1321c WIP: Don't report custom type constructors used as phantom types 2020-03-09 22:42:16 +01:00
Jeroen Engels
e438da283d Copy over NoUnused.CustomTypeConstructors temporarily 2020-03-09 21:21:38 +01:00
Jeroen Engels
c141fdb1ae Rename module rule's phantom fields to canCollectProjectData 2020-03-08 00:54:18 +01:00
Jeroen Engels
0d33ab05e7 Improve the error message when Review.Test.runOnModules is given an empty list 2020-03-07 20:11:07 +01:00
Jeroen Engels
801fae798a Remove version from dependency data 2020-03-07 19:57:16 +01:00
Jeroen Engels
37981b65db Make Dependencies opaque 2020-03-07 18:38:39 +01:00
Jeroen Engels
ec326af739 Write NoDebugTodoOrToString rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
8f1ec1dd3a Write NoDebugLog rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
5cfd68fb6b Rename withModuleDependenciesVisitor to withDependenciesModuleVisitor 2020-03-02 22:53:37 +01:00
Jeroen Engels
c09c46e4eb Rename withProjectElmJsonVisitor to withElmJsonProjectVisitor 2020-03-02 22:52:31 +01:00
Jeroen Engels
8406c29fd3 Rename withModuleElmJsonVisitor to withElmJsonModuleVisitor 2020-03-02 22:51:25 +01:00
Jeroen Engels
0b0b6d1b85 Use "List nothing" instead of "List Error" where possible 2020-02-28 17:11:15 +01:00
Jeroen Engels
d7f645241d Continue documentation for project rules 2020-02-27 19:19:33 +01:00
Jeroen Engels
fbcc11d6a9 Simplify Scope by not having a setter and getter 2020-02-16 23:29:11 +01:00
Jeroen Engels
c2c53fdbe6 Rename Rule.FileKey to Rule.ModuleKey 2020-02-16 21:54:05 +01:00
Jeroen Engels
382a6c8604 Add NoInvalidLicense 2020-02-16 21:40:59 +01:00
Jeroen Engels
c652a24d48 Store more information about the project's dependencies 2020-02-16 21:40:59 +01:00
Jeroen Engels
a91d66ea60 Add Review.Test.expectErrorsForElmJson 2020-02-16 16:56:33 +01:00
Jeroen Engels
0f39773e75 Change how dependencies are stored, and add NoUnused.Dependencies rule 2020-02-16 16:56:33 +01:00