microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-15 14:11:50 +03:00
Code Issues Projects Releases Wiki Activity
11,417 Commits 32 Branches 139 Tags 214 MiB
567386c23f
Commit Graph

3455 Commits

Author SHA1 Message Date
Yury Semikhatsky
9575867f1c
fix(blob): throw if blob report has newer version than the merger (#24593) 2023-08-03 15:11:34 -07:00
Max Schmitt
2193903d03
chore: allow calling spawnSync on Node.js file inside test (#24539) 
Fixes https://github.com/microsoft/playwright/issues/24516 

Relates https://github.com/microsoft/playwright/pull/16733
 2023-08-04 00:03:14 +02:00
Yury Semikhatsky
8e2f33673b
chore(blob): change file name to report{-suffix}{-shard}.zip (#24592) 2023-08-03 13:23:30 -07:00
Playwright Service
b4c9f5ab89
feat(webkit): roll to r1882 (#24584) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-03 17:40:54 +02:00
Yury Semikhatsky
a867e738db
chore(merge): console status updates (#24559) 2023-08-02 14:49:06 -07:00
Max Schmitt
b0473b71cd
chore: limit docs snippet length to 100 (#24563) 2023-08-02 11:23:47 +02:00
Yury Semikhatsky
f5d069541d
chore(blob): add version to metadata (#24556) 2023-08-01 16:06:06 -07:00
Yury Semikhatsky
8da37b364b
chore(blob): zip output directory by default (#24536) 
Changed the logic to add attachment to the zip in onEnd rather than
onTestEnd because attachment files can be deleted if e.g. preserveOutput
option is specified. Instead we add files once all workers have been
shut down. On a simple run with 1000 tests each adding 1Mb attachment
the overall time difference is 49s (streaming attachments) v 1m9s
(attachments added in the end).
 2023-08-01 15:21:23 -07:00
Yury Semikhatsky
ce341ae5b5
docs: clarify setContent semantics (#24553) 
Fixes https://github.com/microsoft/playwright/issues/24503
 2023-08-01 11:45:58 -07:00
Playwright Service
9d5d2c60bb
feat(firefox-beta): roll to r1422 (#24533) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-08-01 04:28:30 -07:00
Sander
7c5d73a3c3
feat(ct): vue type safe mount props (#23151) 2023-07-31 17:45:34 -07:00
Sander
98cba15938
feat(ct): vue2 type safe mount props (#23194) 2023-07-31 17:44:43 -07:00
Playwright Service
dc5e201611
feat(firefox): roll to r1422 (#24531) 
Fixes https://github.com/microsoft/playwright/issues/24132

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-31 17:10:22 -07:00
Pavel Feldman
009f9994df
fix(html): mobile layout for filters (#24506) 2023-07-31 16:54:07 -07:00
Playwright Service
77b1ec4a53
feat(webkit): roll to r1881 (#24521) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-31 23:31:35 +02:00
Andrey Lushnikov
f135b5f7a8
fix: make sure monotonicTime() value is reasonable (#24518) 
https://github.com/microsoft/playwright/issues/24432
 2023-07-31 09:42:08 -07:00
Dmitry Gozman
d92fe16b76
fix(blob report): default location relative to package.json (#24481) 
Also:
- remove `blob-report` directory at the start;
- markdown's `report.md` next to package.json;
- use default location in playwright's workflows.

References #24451.
 2023-07-28 15:49:31 -07:00
Dmitry Gozman
a74101d98f
docs: document expect's asymmetric matchers (#24498) 
References #24460, #24417.
 2023-07-28 14:04:01 -07:00
Playwright Service
947637d19f
feat(webkit): roll to r1880 (#24496) 2023-07-28 21:26:43 +02:00
Pavel Feldman
b5d49d0849
chore: do not pass access-key header into the redirects (#24478) 2023-07-27 19:03:14 -07:00
Dmitry Gozman
9c70a75d48
fix(merge): make sure testId from different blobs are unique (#24475) 
Fixes a scenario where each shard runs the same setup project.

References #24451.
 2023-07-27 18:54:00 -07:00
Dmitry Gozman
1754755684
fix(tracing): make sure resetForReuse does not throw (#24415) 
When trace chunk recording is in progress, calling `stop()` throws
`Error: Must stop trace file before stopping tracing`.
 2023-07-27 08:06:42 -07:00
Dmitry Gozman
1b233a5ae2
fix(trace viewer): do not serve 304 responses (#24435) 
These do not have any content, and we should server the original
response that was cached by the browser.

Fixes #24255.
 2023-07-27 08:06:00 -07:00
Playwright Service
9b364f072d
feat(chromium-tip-of-tree): roll to r1136 (#24463) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 15:46:16 +02:00
Playwright Service
b1ea9507a8
feat(chromium): roll to r1074 (#24461) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 15:02:40 +02:00
Playwright Service
7524894512
feat(firefox-beta): roll to r1421 (#24439) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 01:29:38 -07:00
Playwright Service
682a7f0227
feat(firefox): roll to r1421 (#24433) 
Fixes https://github.com/microsoft/playwright/issues/22590

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-27 01:29:17 -07:00
Dmitry Gozman
c8f2fc392a
chore: move fs operation in trace recorder to a separate class (#24383) 2023-07-26 17:31:00 -07:00
Dmitry Gozman
ea6d127f28
feat(connect): exposeNetwork option (#24436) 2023-07-26 17:29:31 -07:00
Dmitry Gozman
e0cbb0882b
fix(launch): default to non-zero launch timeout (#24440) 
When not specified, launch timeout is 3 minutes, taken from the
`DEFAULT_LAUNCH_TIMEOUT` constant.
Also, use the default launch timeout for `electron.launch()` instead of
default regular timeout.
 2023-07-26 16:16:00 -07:00
Dmitry Gozman
c8b45aa844
chore: validate markdown links in doclint (#24444) 
Fixes #24421.
 2023-07-26 16:15:07 -07:00
Dmitry Gozman
4be1e479ea
fix(artifacts): only attach screenshot when it succeeds (#24406) 
Fixes #24378.
 2023-07-26 15:22:04 -07:00
Pavel Feldman
4949cef09c
chore: save chrome trace on the client side (#24414) 2023-07-26 14:11:26 -07:00
Dmitry Gozman
ed99ac7395
fix(sigint): make sure we do not add handler twice (#24413) 
In the following scenario, we were adding SIGINT handler twice, but
removing it just once:
- Task runner starts testing, creates SigIntWatcher, installs SIGINT
handler.
- Press Ctrl+C, task runner interrupts, disarms SigIntWatcher, SIGINT
handler is not removed due to 1000ms cooldown.
- Task runner starts cleanup, creates SigIntWatcher, installs another
SIGINT handler.
- Cleanup finishes, SigIntWatcher disarms, could remove or not remove
SIGINT handler based on timing (same 1000ms cooldown). In any case, we
have one or two SIGINT handlers still on.
- HTML reporter hangs in onExit, while we still have SIGINT handler up,
so Ctrl+C does not exit.

Regressed in #24265.
 2023-07-25 18:35:38 -07:00
Pavel Feldman
b39fd7283f
chore: skip tests that fail in cross-machine service mode (#24412) 2023-07-25 16:47:04 -07:00
Dmitry Gozman
9d0bba9c99
fix(tracing): do not throw on missing attachments (#24409) 
Fixes #24378.
 2023-07-25 14:32:56 -07:00
Pavel Feldman
33d62d9a97
chore: do not use relative xpath when querying from document (#24405) 
Fixes https://github.com/microsoft/playwright/issues/24399
 2023-07-25 12:55:35 -07:00
Playwright Service
afd6f7d342
feat(chromium-tip-of-tree): roll to r1135 (#24393) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-25 15:05:56 +02:00
Max Schmitt
5c41c6e799
chore: allow installing Google Chrome on Debian (#24386) 
Fixes https://github.com/microsoft/playwright/issues/24357
 2023-07-25 00:52:19 +02:00
Dmitry Gozman
4c8912f74e
chore: remove separate process that cleans up directories (#24376) 
A separate process is `spawnSync`'ed on process exit to cleanup
temporary directories, introduced in #13769 that followed up after
#13343.

A separate process might stall for various fs-related issues, which
prevents the original process from exiting.

With the recent changes, we always gracefully close and cleanup after
all launched executables before calling `process.exit()`, and so it
should only be possible to leave temp directories when using Playwright
and calling `process.exit()` programmatically without closing browsers.

We can now drop the extra process and rely on `rimraf.sync` for
last-resort cleanup in these rare circumstances.
 2023-07-24 15:24:29 -07:00
Sander
1abff78de2
fix(ct): remove json typechecking (#24114) 2023-07-24 15:22:20 -07:00
Marcin Strzyz
78a2b7237e
feat: add screen definitions for ipad gen 5 (#24355) 2023-07-24 14:57:12 -07:00
Pavel Feldman
4ba6d789bc
Revert "chore: refactor timeout manager to use scopes (1) (#24315)" (#24382) 
This reverts commit f5df0940c9.
 2023-07-24 14:09:20 -07:00
Playwright Service
d144c5e6e3
feat(webkit): roll to r1879 (#24380) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-24 22:40:54 +02:00
Andrey Lushnikov
fee08a6d3b
fix: properly handle character sets in globs (#24371) 
https://github.com/microsoft/playwright/issues/24316
 2023-07-24 09:49:05 -07:00
Dmitry Gozman
b4c412eb1f
chore: replace process.exit with graceful closure (#24242) 
Everywhere we call `process.exit()`, we might actually need to
gracefully close all browsers.
 2023-07-24 08:29:29 -07:00
Alex Ravenna
b93b2a7155
docs: fix minor grammar and text issues (#24331) 2023-07-24 14:59:15 +02:00
Dmitry Gozman
2cb0622c39
chore: rename ScopedRace to LongStandingScope, preserve Error instance in reject() (#24361) 2023-07-23 21:00:07 -07:00
Marcin Strzyz
2070861807
chore: ensure the file operations are async in the json reporter. (#24356) 2023-07-23 09:26:32 +02:00
Yury Semikhatsky
6a3721eb9c
chore: delete --attachments option from merge-reports command (#24350) 
We recommend uploading all resources along with the generated report. If
need be we'll reconsider adding the option later.
 2023-07-21 13:15:00 -07:00
Andrey Lushnikov
d307c8e63a
fix(ssim-cie94): make sure a single off pixel yields diff in comparator (#24348) 
This patch brings in antialiasing tests from `looks-same` project for
our experimental `ssim-cie94` comparator.

One of the new tests found a bug in our implementation.

References https://github.com/microsoft/playwright/issues/24312
 2023-07-21 12:27:52 -07:00
Playwright Service
aa39f39bda
feat(webkit): roll to r1878 (#24340) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-21 09:55:30 +02:00
Pavel Feldman
f5df0940c9
chore: refactor timeout manager to use scopes (1) (#24315) 2023-07-20 17:21:21 -07:00
Dmitry Gozman
767addec8c
chore: make sure to call task's teardown if it has ever started (#24317) 
This way things like WebServerPlugin can cleanup after themselves even
if they failed to start or were interrupted mid-way.
 2023-07-20 17:16:22 -07:00
Yury Semikhatsky
59d5198d17
fix(fetch): handle negative max-age and expires attributes (#24311) 
Fixes #24221
 2023-07-20 15:42:52 -07:00
Playwright Service
57305e985e
feat(webkit): roll to r1877 (#24330) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-20 17:47:21 +02:00
Playwright Service
80daf47d44
feat(chromium): roll to r1073 (#24326) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-20 16:15:56 +02:00
Playwright Service
7ba60ca91d
feat(chromium-tip-of-tree): roll to r1134 (#24325) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-20 16:15:40 +02:00
Playwright Service
eac47ce913
feat(webkit): roll to r1876 (#24302) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-19 18:24:59 +02:00
Playwright Service
20fcd6b272
feat(webkit): roll to r1875 (#24299) 
Since
99ff08340f
search event is disabled in cocoa.

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-19 18:24:21 +02:00
Max Schmitt
1288519915
fix(ui-mode): run teardown handlers with Command + C (#24267) 
Fixes https://github.com/microsoft/playwright/issues/23907
 2023-07-19 17:50:25 +02:00
Andrey Lushnikov
1fdd7541e0
chore: add firefox-asan for stress tests (#24049) 2023-07-19 05:53:52 -07:00
Playwright Service
fbb384483b
feat(webkit): roll to r1874 (#24297) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-19 14:20:19 +02:00
Playwright Service
a136763118
feat(webkit): roll to r1873 (#24296) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-19 14:19:05 +02:00
Max Schmitt
9af0c6d822
chore: remove glob dependency from utils bundle (#24291) 2023-07-19 05:17:34 +02:00
Pavel Feldman
879ddb73b0
chore: show last poller error on test timeout (#24292) 2023-07-18 17:03:26 -07:00
Marcin Strzyz
d5e7b4f16f
chore: update rimraf package to version 4 to eliminate "promisify" (#24190) 
Migrate to version 4 which returns a promise rather than leverages a
callback. -> https://www.npmjs.com/package/rimraf?activeTab=readme

- contains its own types, eliminate "@types/rimraf"
- Parameter `maxBusyTries` changed to `maxRetries`
 2023-07-18 19:58:07 +02:00
Marcin Strzyz
0eb94aaa79
chore: refactored minimum Node Major version to variable (#24188) 2023-07-18 19:57:48 +02:00
Max Schmitt
d2f581a19c
fix(test-runner): don't double emit SIGINT in long running test (#24265) 
https://github.com/microsoft/playwright/issues/23907

This fixes the following scenario. You press Command + C during the
test-execution, then a global teardown will execute, which takes a long
time and before this on macOS did sometimes end up in an unwanted SIGINT
received inside the globalTeardown handler. After this change this won't
happen anymore.
 2023-07-18 18:46:18 +02:00
Yury Semikhatsky
d0280ec8c7
chore(blob): drop shard number from report name (#24270) 
We store shard number in the report metadata event and then sort shard
files by shard number. This guarantees that within each project sharded
events will always go in stable order.
 2023-07-18 09:29:25 -07:00
Playwright Service
b24ec33aa9
feat(chromium-tip-of-tree): roll to r1133 (#24280) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-18 15:11:01 +02:00
Playwright Service
57da4c200a
feat(chromium): roll to r1072 (#24279) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-18 15:10:30 +02:00
Pavel Feldman
5ff1fadd7b
chore: apply only filtration to deps (#24268) 2023-07-17 16:48:52 -07:00
Yury Semikhatsky
f6540f89ea
chore(markdown): do not print details for flaky tests (#24264) 2023-07-17 16:09:59 -07:00
Yury Semikhatsky
15b9e5afdb
fix: print fatal and no snippet errors in markdown report (#24263) 2023-07-17 13:50:00 -07:00
Pavel Feldman
49c1f9eb02
feat(ui): run deps in UI mode if dep projects are checked (#24245) 2023-07-15 15:11:31 -07:00
Yury Semikhatsky
3616023cf6
chore: markdown report details (#24237) 2023-07-14 12:32:25 -07:00
Dmitry Gozman
97d55e275d
fix(locator): locator(locator) method uses internal:chain instead of >> (#24235) 
Usually, we can just chain two locators with `>>` to implement
`Locator.locator(locator)`. However, this does not play nicely with more
advanced inner locators like `or` and `and`:

```ts
const child = page.locator('input').or(page.locator('button'));
page.locator('parent').locator(child);
```

One would expect the above to locate "input or button" inside a
"parent". However, currently it locates "input inside a parent" or
"button", because it's translated to `parent >> input >>
internal:or="button"`.

To fix this, we have to wrap inner locator into `internal:chain` and
query it separately from the parent.

Fixes #23724.
 2023-07-14 12:21:45 -07:00
Dmitry Gozman
98f3ca05b9
fix(tracing): only access tracing state on the API calls, not inside trace operations (#24212) 
References #23387.
 2023-07-14 06:19:54 -07:00
Pavel Feldman
5d799606c3
chore: resolve top-level vs dependency after cli filtering (#24216) 2023-07-13 17:54:08 -07:00
Pavel Feldman
33bab3652d
fix(ui): bump min sidebar size (#24193) 2023-07-13 15:14:49 -07:00
Max Schmitt
57cca1d96e
Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 
This reverts commit 4b1b4dc23b.

https://github.com/microsoft/playwright/issues/24184

Reopens https://github.com/microsoft/playwright/issues/23386
 2023-07-13 20:03:02 +02:00
Max Schmitt
b483bf9fcc
feat: add support for Debian 12 for Firefox/WebKit (#24206) 
https://github.com/microsoft/playwright/issues/23532

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
 2023-07-13 12:56:44 +02:00
Andrey Lushnikov
615f5afb2b
feat(firefox): roll Firefox to 1420 (#24205) 
Fixes https://github.com/microsoft/playwright/issues/22753
 2023-07-13 03:54:47 -07:00
Playwright Service
7787988043
feat(webkit): roll to r1872 (#24201) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-13 11:07:33 +02:00
Playwright Service
04be72213b
feat(chromium-tip-of-tree): roll to r1132 (#24204) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-13 10:58:13 +02:00
Dmitry Gozman
53feeaf270
fix(tracing): avoid trace file name collisions (#24191) 
We have been optionally adding `-<number>` in multiple places, and these
might collide in various circumstances, for example: two contexts at the
same time, one of them has the second trace chunk.

References #23387.
 2023-07-12 17:20:25 -07:00
Pavel Feldman
53bf1995db
chore: do not leak internal page handles after closing page (#24169) 
Partial fix for https://github.com/microsoft/playwright/issues/6319

After this fix, the following scenario won't leak and the context state
(cookies, storage, etc) can be reused by the new page sessions:

```js
  for (let i = 0; i < 1000; ++i) {
    const page = await context.newPage();
    await page.goto('...');
    await page.close('...');
  }
```
 2023-07-12 14:51:13 -07:00
Max Schmitt
a0b0752662
fix: encode launch options correctly when reusing browser (#24174) 
Fixes https://github.com/microsoft/playwright/issues/24157
 2023-07-12 16:40:55 +02:00
Playwright Service
6e02fda2a0
feat(firefox-beta): roll to r1419 (#24165) 
Fixes https://github.com/microsoft/playwright/issues/24081

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-12 03:28:20 -07:00
Dmitry Gozman
76d85c55cf
chore: remove unused code (#24167) 2023-07-11 15:08:05 -07:00
Pavel Feldman
067faa50d7
chore: migrate Promise.race to scopes to prevent leaks (#24160) 2023-07-11 10:38:08 -07:00
Dmitry Gozman
aeba083da0
fix(snapshots): match resources by method (#24145) 
Fixes #24144.

Previously, we only matched by url, which confuses GET and HEAD requests
where the latter is usually zero-sized.

Also make sure that resources are sorted by their monotonicTime, since
that's not always the case in the trace file, where they are sorted by
the "response body retrieved" time.
 2023-07-10 20:04:48 -07:00
Pavel Feldman
63915dc07a
feat(trace): render Node console messages in trace (#24139) 2023-07-10 18:36:28 -07:00
dependabot[bot]
36588ba98e
chore(deps): bump semver and @babel/core in /packages/playwright-test/bundles/babel (#24082) 
Fixes https://github.com/microsoft/playwright/issues/23903

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-07-10 23:40:28 +02:00
Max Schmitt
1c2313d641
chore: upgrade esbuild to 0.18.11 (#24123) 2023-07-10 22:35:05 +02:00
Pavel Feldman
67ad2c2bf4
feat(ui): render all console / network messages in trace (#24115) 2023-07-10 12:56:56 -07:00
Andrey Lushnikov
94d6b1210b
fix: do not create empty directories for successful snapshot tests (#24127) 
Fixes https://github.com/microsoft/playwright/issues/15600
 2023-07-10 09:45:24 -07:00
Andrey Lushnikov
19474bef78
chore: update WebKit browser version to 17.0 (#24128) 2023-07-10 08:08:00 -07:00
Playwright Service
b4ffb848de
feat(webkit): roll to r1870 (#24119) 2023-07-10 08:09:08 +02:00
Pavel Feldman
50ba25e9a1
fix(trace): do not allow after w/o before (#24106) 
Fixes https://github.com/microsoft/playwright/issues/24087,
https://github.com/microsoft/playwright/issues/23802
 2023-07-07 17:16:26 -07:00
Andrey Lushnikov
a9560253f8
chore: cut 1.36.0 (#24104) 2023-07-07 13:01:17 -07:00
Playwright Service
9bca9f1b4f
feat(chromium): roll to r1071 (#24098) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-07 16:51:03 +02:00
Playwright Service
90c92c5724
feat(firefox): roll to r1419 (#24091) 
Fixes https://github.com/microsoft/playwright/issues/24080

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-06 22:43:03 -07:00
Andrey Lushnikov
b9e68e22e0
feat: support Chromium installation on Debian 12 (#24090) 
This adds Chromium support for both x86 and arm64 versions of Debian 12.

References https://github.com/microsoft/playwright/issues/24028
 2023-07-06 22:41:36 -07:00
Andrey Lushnikov
9af2b518f2
fix: exclude tracesDir option from launchOptions fixture (#24086) 
Fixes https://github.com/microsoft/playwright/issues/23645
 2023-07-06 13:31:44 -07:00
Andrey Lushnikov
11dce8d127
feat(firefox): roll Firefox to 1417 (#24069) 
Fixes https://github.com/microsoft/playwright/issues/23280
 2023-07-06 12:18:02 -07:00
Pavel Feldman
0409bfca56
chore: ensure module deps in ct-core (#24056) 
Fixes https://github.com/microsoft/playwright/issues/23823
 2023-07-06 12:01:45 -07:00
Pavel Feldman
608e336dba
fix(error): create a step for raw runtime error (#24057) 
Fix https://github.com/microsoft/playwright/issues/23850
 2023-07-06 10:48:12 -07:00
Pavel Feldman
566b277ce8
fix(steps): only propagate soft errors up the hierarchy (#24054) 
Fixes https://github.com/microsoft/playwright/issues/23979
 2023-07-05 15:30:53 -07:00
Andrey Lushnikov
ea3a29eacd
feat(firefox): roll Firefox to 1415 (#24046) 
Fixes https://github.com/microsoft/playwright/issues/23618
 2023-07-05 11:58:38 -07:00
Pavel Feldman
df57fb594c
fix(trace): render items under expect.toPass (#24016) 
Fixes: https://github.com/microsoft/playwright/issues/23942
 2023-07-05 11:20:28 -07:00
Playwright Service
9f1f737acb
feat(chromium): roll to r1070 (#23991) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-03 21:27:07 +00:00
Playwright Service
b3c4f45759
feat(webkit): roll to r1869 (#24011) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-07-03 21:26:46 +00:00
Pavel Feldman
6343ea2795
feat(trace): allow scrolling the filmstrip (#24015) 
Fixes https://github.com/microsoft/playwright/issues/23963
 2023-07-03 13:03:33 -07:00
Patrick Shaw
6e78dcb7dc
fix: Allow portable bash paths for systems including NixOS (#23889) 
Although very common, bash is not guaranteed to be located at
`/bin/bash`. NixOS is an example of this.

More commonly, `/bin/bash` can be quite out of date. An example of this
is MacOS's version of `bash`. This realistically won't affect Playwright
but it's worth noting. You can technically update MacOS's system version
of bash but you need elevated permissions to do so.

By using `/usr/bin/env bash` instead of `/bin/bash` we can execute
Playwright's bash scripts in like NixOS and generally improve the
selection behaviour for bash in other systems too.

Some discussion of why it's worth favouring `/usr/bin/env bash` over
`/bin/bash`:
- Discusses `/bin/bash` missing in NixOS:
https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673
- Some general commentary on why `/usr/bin/env bash` is favoured:
https://askubuntu.com/a/1402721
- Points out how old bash is in MacOS:
https://itnext.io/upgrading-bash-on-macos-7138bd1066ba

Improves situation at #5501
 2023-07-03 06:27:06 -07:00
Dmitry Gozman
7e310f79af
chore: migrate builtin reporters to ReporterV2 (#23985) 
This allows builtin reporters to handle stdio between onConfigure and
onBegin.

Fixes #23539.
 2023-06-30 16:21:31 -07:00
Dmitry Gozman
86c1abd934
chore: introduce ReporterV2 interface (#23983) 2023-06-30 13:36:50 -07:00
Dmitry Gozman
92c738b14a
test: unflake some tests (#23984) 2023-06-30 13:08:18 -07:00
Dmitry Gozman
e28312ba63
chore: call onEnd(result) on InternalReporter (#23972) 
Drive-by: fix watch mode not running global teardown.
 2023-06-29 17:03:10 -07:00
Max Schmitt
a07626b804
feat(webkit): roll to r1868 (#23969) 
GitHub had an outage so the PR didn't get created automatically.

Closes https://github.com/microsoft/playwright/pull/23931.
 2023-06-29 23:27:48 +02:00
Max Schmitt
fef029e98e
docs: code snippet alignments (#23959) 2023-06-29 18:26:19 +02:00
Playwright Service
c2127595b8
feat(chromium-tip-of-tree): roll to r1128 (#23956) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-29 15:17:16 +02:00
Dmitry Gozman
1d0b48f18b
fix(route): handle escapes in the glob pattern (#23932) 
Fixes #23303.
 2023-06-28 16:33:04 -07:00
Dmitry Gozman
1ab99fe1b8
feat(electron): support tracesDir option (#23947) 
References #23620.
 2023-06-28 16:32:16 -07:00
Dmitry Gozman
b0b429fed0
feat: support bigint in evaluates (#23930) 
Fixes #22719.
 2023-06-28 08:55:45 -07:00
Playwright Service
2808f3700a
feat(chromium-tip-of-tree): roll to r1127 (#23923) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-27 15:25:01 +02:00
Max Schmitt
9980f054bc
docs: align Node.js code snippets with ESLint (#23916) 2023-06-27 11:53:53 +02:00
Max Schmitt
4b1b4dc23b
fix: do not collide with other tests when test names have special chars (#23414) 
Fixes https://github.com/microsoft/playwright/issues/23386
 2023-06-27 10:34:31 +02:00
Max Schmitt
dcdf38f119
chore: keep UI Mode running when used with browser mode (#23876) 
This will keep UI Mode running in browser mode. When launched in normal
persistent context mode, we know when the persistent context closes, so
we can run the project teardown code.

Fixes https://github.com/microsoft/playwright/issues/23801
 2023-06-26 22:21:44 +02:00
Max Schmitt
e1c220a37b
fix(trace-viewer): file path contains encoded characters (#23893) 
This fixes:

```
npx playwright show-trace %20I%20Love%20Node.zip
```

Extracted from https://github.com/microsoft/playwright/pull/23414.
 2023-06-26 18:13:40 +02:00
zhengjitf
6f67f6b52b
fix(chromium): can get correct orientation angle on non-mobile devices (#23796) 
Fix #23772
 2023-06-23 11:34:09 -07:00
Playwright Service
f85480a12e
feat(firefox-beta): roll to r1415 (#23866) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
 2023-06-23 07:03:20 -07:00
Dmitry Gozman
5821c547aa
fix(selector generator): use the same label definition as getByLabel (#23846) 
This extracts `getElementLabels` helper function to be used both for
generating and querying.
 2023-06-22 08:34:08 -07:00
Moritz Horstmann
bdac3e28a6
fix: best-effort support for TUXEDO OS (#23813) 
TUXEDO OS is an Ubuntu based distribution built by the Linux computer
vendor TUXEDO.
 2023-06-22 07:14:18 -07:00
Playwright Service
ddc0278d81
feat(chromium-tip-of-tree): roll to r1126 (#23858) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-22 15:55:16 +02:00
Playwright Service
f7ecb7094d
feat(chromium): roll to r1069 (#23856) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-22 15:54:56 +02:00
Playwright Service
f7ae17db09
feat(webkit): roll to r1865 (#23847) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-22 12:07:49 +02:00
Dmitry Gozman
b154ff1190
fix(html reporter): do not print epilogue in list mode (#23822) 
References #23817.
 2023-06-21 17:53:52 -07:00
Max Schmitt
605dfde2be
chore: rename popout.html to snapshot.html in trace viewer (#23842) 
Turns out its caused by a uBlockOrigin EasyList entry which thinks we
are an ad since we call ourselves "popout.html". See this entry:


e7883cfe74/easylist/easylist_general_block_popup.txt (L42)

Fixes https://github.com/microsoft/playwright/issues/23799
 2023-06-21 21:10:50 +02:00
Ben Hofferber
752176fd23
feat(goto): better navigation error message (#23609) 
While this log message is only a sanity check, it is still beneficial to
have a message that can better inform what is happening when this
occurs.
 2023-06-21 11:10:35 -07:00
awatson-scottlogic
3777fc8b0f
docs(class-testoptions): fix launchOptions snippet (#23831) 2023-06-21 14:03:26 +02:00
Yury Semikhatsky
6a6ff9cf6a
feat: markdown report (#23819) 
Simple markdown report generator. Can be used when posting updates to
GitHub PRs:

<img width="632" alt="image"
src="https://github.com/microsoft/playwright/assets/9798949/ea7e4bfa-477a-4cad-9cc3-00b1f8a314b1">
 2023-06-20 12:11:32 -07:00
Andrey Lushnikov
1736479e41
fix: fix locator picker in Trace (#23820) 
- make sure links are not clickable with enabled locator picker
- make sure locator picker state is preserved when switching actions
 2023-06-20 11:39:21 -07:00
Playwright Service
270135faaf
feat(chromium-tip-of-tree): roll to r1125 (#23806) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-20 16:15:22 +02:00
Playwright Service
7a060d13f0
feat(webkit): roll to r1864 (#23794) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-20 09:29:15 +02:00
Dmitry Gozman
fe5c9dad4d
fix(locators): allow identical frameLocators inside and/or/has (#23740) 
So, the following will work:

```
page.frameLocator('iframe').locator('span').or(page.frameLoactor('iframe').locator('div'))
```

The following will not work, because frame locators are not exactly the
same:

```
page.frameLocator('#iframe1').locator('span').or(page.frameLoactor('#iframe2').locator('div'))
```

Also improve the error message to be more readable and include the
locator.

Fixes #23697.
 2023-06-19 15:22:26 -07:00
Dmitry Gozman
fbb5d48283
feat(expect): roll to v29.5.0 (#23629) 
There is a breaking in change in the `MatcherContext` that is passed to
matcher functions, so we now have `!!this.isNot` in a few places. The
same could happen to custom matcher in the wild.

```ts
// Old
{
  isNot: boolean;
  promise: string;
}
```

```ts
// New
{
  isNot?: boolean;
  promise?: string;
}
```

Fixes #23612.
 2023-06-19 15:18:59 -07:00
Dmitry Gozman
2c8dd67b0e
fix(test runner): improve error message for non-stable test titles (#23792) 
Fixes #23779.
 2023-06-19 14:13:11 -07:00
Sander
9d3edb0aa3
fix(ct): vue3 fallthrough events & callbacks (#23649) 
closes:
https://github.com/microsoft/playwright/issues/23526#issuecomment-1583074280

closes: https://github.com/microsoft/playwright/issues/23435
 2023-06-19 11:20:37 -07:00
vemv
380209af37
chore: log when websockets are proactively closed (#23689) 
Closes https://github.com/microsoft/playwright/issues/23566

n.b., while that issue describes a fairly specific "use case", this
logging is simple and generic. It seems very plausible that it can help
diagnose all sorts of issues.

Cheers - V
 2023-06-19 11:12:02 -07:00
Max Schmitt
0f9f863183
fix(codegen): generate no Enter keyboard events for textareas (#23775) 
Fixes https://github.com/microsoft/playwright/issues/23774
 2023-06-19 17:07:37 +02:00
Andrey Lushnikov
e171194c86
feat(firefox): roll Firefox to 1414 (#23768) 
- roll Firefox stable to 1414
- roll Firefox beta to 1414

Fixes #23138
 2023-06-17 12:10:20 -07:00
Dmitry Gozman
132a5a4bf5
fix(trace viewer): prefer latest resource with the same url (#23763) 
When rendering snapshot, disregard earlier resources with the same url,
because it's most likely that the latest one was used for rendering.

An example would be reloading the page before the stylesheet has
finished loading. In this case, the stylesheet will be requested twice,
and the second copy that was not aborted should be used for the
snapshot.

Fixes #23709.
 2023-06-17 06:58:16 -07:00
Yury Semikhatsky
f6d86c20f3
chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
Dmitry Gozman
09b1e3ffa9
fix(chromium): response.body() for worker requests should work (#23764) 
Previously, worker requests used page's session to call
`Network.getResponseBody`.

Fixes #23750.
 2023-06-16 20:44:32 -07:00
Max Schmitt
b44723708c
chore: move extracting of browser out-of-process (#23739) 
https://github.com/microsoft/playwright/issues/23729
 2023-06-16 20:40:15 +02:00
Dmitry Gozman
de422b5afb
chore: speedup multiple roleUtils calls (#23745) 
When generating a selector, we tend to match by role and call various
roleUtils methods multiple times.

Apply the usual pattern for "nested operations counter" and aggressively
cache the results.
 2023-06-16 11:39:39 -07:00
Yury Semikhatsky
11770156eb
feat(html): show number of filtered tests, update total time (#23743) 2023-06-16 09:22:57 -07:00
Machiel-B
0358f6c434
fix: make trace viewer not use 301 to redirect (#23757) 2023-06-16 18:16:01 +02:00
Playwright Service
d92a648284
feat(chromium): roll to r1068 (#23756) 2023-06-16 17:57:45 +02:00
Max Schmitt
4d02aa1e52
chore: render locator in trace viewer timeline label (#23754) 2023-06-16 17:56:11 +02:00
Dmitriy Dudkevich
fc8f0101c8
fix(selenium): send additional headers to delete session method (#23719) 
In the process of completing the task -
https://github.com/microsoft/playwright/pull/23348, I didn't notice the
need to pass headers to the session deletion method. So I fixed it here.
And support headers for selenium@3.
 2023-06-16 11:44:04 +02:00
Dmitry Gozman
d11bc88784
chore(codegen): do not use accessible name for non-text selectors (#23717) 
Accessible name usually includes text, so we don't want it for non-text
selectors, e.g. for `expect()` selectors.
 2023-06-15 12:30:18 -07:00
Max Schmitt
8ed956e496
chore: move pw-core utilsBundleImpl into own directory (#23706) 
https://github.com/microsoft/playwright/issues/23666
 2023-06-15 20:16:47 +02:00
Playwright Service
bad09acb87
feat(webkit): roll to r1863 (#23734) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-15 20:10:54 +02:00
Playwright Service
8602981d87
feat(chromium-tip-of-tree): roll to r1124 (#23733) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-15 17:08:53 +02:00
Yury Semikhatsky
77d322028c
feat(blob): zip .jsonl report files (#23720) 
For linux tests without tracing blob-report-1.zip takes 19M, while
unpacked size is 228 MB. That size is counted for GitHub artifact
billing:

<img width="434" alt="image"
src="https://github.com/microsoft/playwright/assets/9798949/5bc32511-6686-4581-a348-acb6a54cd99b">

We zip individual .jsonl reports so that they still have unique names
and can be easily uploaded into the same artifacts directory without
name collisions.
 2023-06-14 17:10:39 -07:00
Max Schmitt
60de8308a8
chore: bundle open's xdg-open script (#23710) 2023-06-14 20:49:26 +02:00
Andrey Lushnikov
dc81cfaf81
Revert "fix: scroll timeline with multiple pages in context (#23493)" (#23711) 
This reverts commit a4d361379f.

Reason for revert: this breaks screencast preview (the image
that is shown when you hover over the screencast).
 2023-06-14 11:41:42 -07:00
Andrey Lushnikov
3c0fab489b
chore: miscellaneous trace viewer fixes (#23695) 
- properly annotate continued requests
- nest `attach` steps inside the related `expect` step
- fix primary-id-to-non-primary-id mapping
- make sure images in trace are not draggable

Fixes #23693

---------

Signed-off-by: Andrey Lushnikov <aslushnikov@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-06-14 09:37:19 -07:00
Max Schmitt
9e636687ea
chore: add more logging for browser install process (#23675) 2023-06-14 15:33:06 +02:00
Dmitry Gozman
5b2e8a6a7a
chore: optional root for generateSelector (#23692) 2023-06-13 21:25:39 -07:00
Dmitry Gozman
c80a23842b
fix(css): relative-to-scope selectors work (#23665) 
Chained selectors where the second part starts with a scope did not work
before:

```ts
page.locator('div').locator(':scope + span')
page.locator('div >> +span')
```
 2023-06-13 10:27:25 -07:00
Playwright Service
76532160d3
feat(chromium-tip-of-tree): roll to r1123 (#23682) 2023-06-13 19:17:57 +02:00
Playwright Service
769b449d86
feat(webkit): roll to r1862 (#23678) 2023-06-13 14:55:22 +02:00
Andrey Lushnikov
2bc8cf2fc7
fix: drop expect.configure({ poll }) from types (#23661) 
`poll` option is not actually supported as of June 12, 2023.

Fixes https://github.com/microsoft/playwright/issues/23622
 2023-06-12 11:07:39 -07:00
Dmitry Gozman
dd417d83d9
fix(locators): escape >> inside a regular expression (#23631) 
To avoid selector being parsed as a chain.

Fixes #23540.
 2023-06-12 10:34:37 -07:00
Yury Semikhatsky
abdfe264fa
chore: run html reporter tests with merged report (#23626) 2023-06-09 15:41:15 -07:00
Yury Semikhatsky
400c7cd529
fix: serialize attachment to base64 in tele reporter (#23590) 2023-06-09 11:52:18 -07:00
Tyler Gould
a4d361379f
fix: scroll timeline with multiple pages in context (#23493) 
Fixes #23490 

Before:
<img width="500" alt="image"
src="https://github.com/microsoft/playwright/assets/4130722/faa1f7c3-9aeb-4e0c-aca3-0d9c24609628">

After:
<img width="500" alt="image"
src="https://github.com/microsoft/playwright/assets/4130722/6dfbc204-8ff2-49cb-a374-734750c6a385">

---------

Signed-off-by: Tyler Gould <4130722+scitech@users.noreply.github.com>
Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
 2023-06-09 09:07:14 -07:00
Dmitry Gozman
734705e9b3
chore: elementHandle getters implemented through Frame (#23557) 
This is a step towards not using handles for locator operations.
 2023-06-09 07:18:13 -07:00
Yury Michurin
7513993c7a
docs: fix a comment typo (#23592) 
Hi,
Just a small meaningless comment typo 🙃 

Have a great day!

Signed-off-by: Yury Michurin <yury.michurin@gmail.com>
 2023-06-08 21:35:04 -07:00
Dmitry Gozman
11659ceb73
fix(role): handle display:contents elements (#23607) 
Fixes #23521.
 2023-06-08 16:00:48 -07:00
Playwright Service
befd188763
feat(chromium-tip-of-tree): roll to r1122 (#23594) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-08 20:35:04 +02:00
Dmitriy Dudkevich
187cfdc328
feat: ability to pass additional headers to selenium (#23348) 2023-06-08 10:41:36 -07:00
Dmitry Gozman
5cfd6d9fe9
fix(cr network): emit sw-handled requests when routing is enabled (#23589) 
Previously, such requests were skipped because they never receive
`Fetch.requestPaused` as there was no real network.

Also cleanup some redundant tests and move them from chromium-only file.

Fixes #23424.
 2023-06-08 10:33:28 -07:00
Playwright Service
54a35dd108
feat(chromium): roll to r1067 (#23593) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-08 19:03:48 +02:00
Playwright Service
a40fa1d86c
feat(webkit): roll to r1861 (#23530) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-08 09:49:07 +02:00
Playwright Service
fa3dd76cf8
feat(chromium-tip-of-tree): roll to r1121 (#23584) 2023-06-08 08:19:12 +02:00
Yury Semikhatsky
ded4a294f4
fix(merge): populate TestResult.stdout/stderr when merging (#23587) 2023-06-07 23:00:57 -07:00
Pavel Feldman
83cf6cc1e8
chore: do not show select item when Show trace (#23583) 2023-06-07 16:11:57 -07:00
Andrey Lushnikov
c3bc8e0620
chore: cut 1.35.0 (#23579) 2023-06-07 12:41:56 -07:00
Dmitry Gozman
4f8680f7a3
fix(pause): revert timeouts after pause (#23578) 
Fixes #23523.
 2023-06-07 12:30:10 -07:00
Pavel Feldman
0b30f2017c
chore: make trace server work over http (#23561) 2023-06-06 18:36:05 -07:00
Andrey Lushnikov
2e327c9d0c
fix: miscellaneous improvements for tracing UI (#23558) 
- feat(tracing): mark API requests with "API" label
- feat(tracing): do not attribute any resources to `route.` API calls;
  otherwise, network traffic might get inside the `route.` actions.
- fix(tracing): map actionIds from primary contexts to actionIds from
  non-primary contexts
- fix(tracing): show leading `/` in URL path in network panel

This is a result of a pair-programming session with @pavelfeldman
 2023-06-06 17:38:44 -07:00
Andrey Lushnikov
0f4090472c
feat: add maskColor option to the toHaveScreenshot method (#23555) 2023-06-06 17:15:55 -07:00
Pavel Feldman
7579572688
chore: unflake the network status test (#23551) 2023-06-06 16:55:53 -07:00
Pavel Feldman
1cd8f7543b
docs: fix the transpiler docs (#23550) 2023-06-06 16:16:06 -07:00
Pavel Feldman
037da65d83
chore: fix ui mode tests on windows (#23553) 2023-06-06 14:24:42 -07:00
Max Schmitt
85be65b07b
chore: update npx playwright uninstall docs (#23552) 2023-06-06 22:09:15 +02:00
Max Schmitt
8bc26a2b44
chore: wait for downloads getting removed on context.close() (#23500) 
Before there was a race, that we ran into this code:


9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L236-L237)

and then into this code:


9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L429-L431)

which had the side effect, that the first call did not wait. Then
immediately clears the downloads Set and then the second call is a NOOP.
This ends up that the the removal of the downloads can happen after the
context is closed, hence the test is flaky.

Relates to https://github.com/microsoft/playwright/pull/6151 where it
got introduced. So something for @yury-s.

Fixes https://github.com/microsoft/playwright/issues/22525
 2023-06-06 20:38:36 +02:00
Max Schmitt
ce2f902c1f
chore: fix UI Mode on Codespaces (#23549) 2023-06-06 20:09:39 +02:00
Pavel Feldman
6351630af2
chore: do not show the open error (#23547) 2023-06-06 11:09:08 -07:00
Pavel Feldman
d4349e5d6f
chore: print listening on message in terminal for web trace modes (#23546) 2023-06-06 09:36:49 -07:00
Pavel Feldman
699ac3a0f2
chore: allow opening ui mode over http (#23536) 2023-06-06 08:31:52 -07:00
dependabot[bot]
0feef340c9
chore(deps): bump vite from 4.3.3 to 4.3.9 (#23537) 2023-06-06 11:12:07 +02:00
Yury Semikhatsky
874f4525b4
fix(merger): total time is sum of shard total times (#23534) 2023-06-05 19:10:41 -07:00
Yury Semikhatsky
ceaa29cec1
chore: clear message for no reports (#23492) 2023-06-05 17:20:54 -07:00
Andrey Lushnikov
3a00fc4edf
fix: call focus() twice to workaround firefox not focusing element (#23535) 
When focus is moved from one tab to another, it might require calling
`focus()` twice to actually focus an element in Firefox.

Fixes https://github.com/microsoft/playwright/issues/23117
 2023-06-05 16:46:52 -07:00
Pavel Feldman
eacfff8127
chore: make trace viewer work over http (#23531) 2023-06-05 16:30:30 -07:00
Dmitry Gozman
6b687b6d69
fix(toHaveScreenshot): attach newly created missing expectations (#23528) 
Fixes #23090.
 2023-06-05 14:57:06 -07:00
Max Schmitt
0e12831a02
chore: hide 'Open in VSCode' for folders in UI Mode (#23499) 2023-06-05 22:09:45 +02:00
KotlinIsland
afa531ef60
feat: Allow multiple trace uploads in the trace viewer (#23517) 2023-06-05 12:34:54 -07:00
Pavel Feldman
def24c0a14
chore: propagate client-side instrumentation across connect (#23524) 
Fixes https://github.com/microsoft/playwright/issues/23504
 2023-06-05 12:28:20 -07:00
Playwright Service
d95b6f40a4
feat(webkit): roll to r1860 (#23494) 
Fixes https://github.com/microsoft/playwright/issues/20489
 2023-06-05 09:51:39 -07:00
Dmitry Gozman
b518d1f6da
chore: update error message when using wrong cli (#23512) 
Now recommends uninstalling other packages. Fixes #23314.

Example messages:

```
Please install @playwright/test package before running "npx playwright show-report"
  npm uninstall playwright playwright-firefox
  npm install -D @playwright/test
```

```
Please install @playwright/test package before running "yarn playwright show-report"
  yarn remove playwright playwright-chromium playwright-firefox playwright-webkit
  yarn add -D @playwright/test
```

```
Please install @playwright/test package before running "pnpm exec playwright show-report"
  pnpm remove playwright
  pnpm add -D @playwright/test
```
 2023-06-05 09:51:08 -07:00
Max Schmitt
80fe9748eb
chore: render plain class links in types (#23508) 2023-06-05 18:50:44 +02:00
Max Schmitt
75971af55b
feat(cli): introduce npx playwright uninstall (#23128) 
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
 2023-06-05 18:50:21 +02:00
Kristo Jorgenson
d5d155df1f
fix(typescript): allow directory imports (#23254) 
This updates previous work in #22887 to align more fully with
`--moduleResolution=bundler`, allowing index files to be imported with
the /index extension

---------

Signed-off-by: Kristo Jorgenson <kristojorg@users.noreply.github.com>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
 2023-06-05 08:58:25 -07:00
Max Schmitt
24ac25212b
chore: enable no-floating-promises on playwright-test (#23484) 2023-06-05 17:45:56 +02:00
Max Schmitt
dcc998d58c
chore: fix broken ct-core require (#23507) 
This broke after https://github.com/microsoft/playwright/pull/23449.
 2023-06-04 18:07:42 +02:00
Gary McDonald
718ee69cb8
docs: fix various spelling mistakes in the docs project directory. (#23510) 
Signed-off-by: Gary McDonald <mcdonagj@dukes.jmu.edu>
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-06-04 18:04:42 +02:00
Max Schmitt
00f662531e
Revert "fix(tracing): workaround chromium scrollTop slowness" (#23486) 
This commit reverts f6712ec43a

I manually ran
https://github.com/microsoft/playwright/issues/14037#issuecomment-1122256514
and made sure that the performance did not regress. ~same.

Fixes https://github.com/microsoft/playwright/issues/23455
 2023-06-02 23:25:55 +02:00
Yury Semikhatsky
401fc4cb9e
fix(tracing): record available response headers without waiting for extra info (#23483) 
Fixes #23115
 2023-06-02 14:15:20 -07:00
Sander
e47b23e5d4
chore(ct): internal types (#23332) 2023-06-02 14:11:03 -07:00
Ivaylo Pavlov
e3f91bbabf
Fix header to pass Selenium Grid Capabilities (#23346) 
Fixes: #23345
 2023-06-02 13:28:23 -07:00
Dmitriy Dudkevich
7ab754f5d5
fix: render actions in ui mode with browsers from selenium (#23382) 2023-06-02 13:24:21 -07:00
Pavel Feldman
5a14619bab
chore: render route markers in the trace network panel (#23476) 
Fixes https://github.com/microsoft/playwright/issues/23040


![net](https://github.com/microsoft/playwright/assets/883973/5191163e-63f9-4999-9197-d10dcd09a665)
 2023-06-02 13:00:27 -07:00
Max Schmitt
af893a1019
chore: inherit apiRequestContext timeout from actionTimeout (#23481) 
Fixes https://github.com/microsoft/playwright/issues/23344
 2023-06-02 21:36:09 +02:00
Max Schmitt
b21c81d344
devops: add bot for Chromium --headless=new (#23440) 
https://github.com/microsoft/playwright/issues/23389
 2023-06-02 20:40:12 +02:00
Dmitry Gozman
835f14d7c9
fix(pause): ignore page.pause on the server (#23417) 
Fixes #23051.
 2023-06-02 08:32:30 -07:00
Playwright Service
82ecd692d1
feat(webkit): roll to r1859 (#23467) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-02 15:05:03 +02:00
Kristo Jorgenson
a4a363f4f4
chore: upgrade @types/node to 16.x (#23429) 
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-06-02 10:04:41 +02:00
Pavel Feldman
d1666d2dde
chore: include test-end-screenshot in a trace (#23457) 
Fixes https://github.com/microsoft/playwright/issues/23222
 2023-06-01 20:29:32 -07:00
Pavel Feldman
96b2247e28
chore: allow marking scripts as external for transform (#23449) 
Fixes https://github.com/microsoft/playwright/issues/22874
 2023-06-01 20:28:49 -07:00
Dmitry Gozman
14a1eaa474
chore: add Playwright to attribution (#23447) 
This makes it easier to plumb all kinds of options around.
 2023-06-01 17:54:43 -07:00
Pavel Feldman
b99c214b29
chore(trace): render drawer as a sidebar in the tv mode (#23451) 
Fixes: https://github.com/microsoft/playwright/issues/23227
 2023-06-01 15:49:48 -07:00
Pavel Feldman
84942aa992
chore: render successful toPass as such (#23411) 
Fixes https://github.com/microsoft/playwright/issues/23302
 2023-06-01 13:22:08 -07:00
Playwright Service
3e73906027
feat(chromium): roll to r1066 (#23433) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-01 16:03:49 +02:00
Playwright Service
fff4e048a8
feat(chromium-tip-of-tree): roll to r1120 (#23431) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-06-01 16:03:33 +02:00
Max Schmitt
5701ff1e9b
chore: do not always return 200 on component testing network requests (#23408) 
Fixes https://github.com/microsoft/playwright/issues/23364

See here about their AppTypes:
https://vitejs.dev/config/shared-options.html#apptype
 2023-06-01 01:33:48 +02:00
Playwright Service
2c700b71ff
feat(webkit): roll to r1858 (#23403) 2023-05-31 23:28:19 +02:00
Dmitry Gozman
6bb5c0a549
fix: make evaluate not wait for scheduled navigations (#23402) 
Fixes #23141.
 2023-05-31 14:08:44 -07:00
Max Schmitt
4eeb4655e9
chore: add comment about async imports in babel (#23374) 
https://github.com/microsoft/playwright/issues/23255
 2023-05-31 18:32:09 +02:00
Pavel Feldman
658b1dfea3
chore: trace viewer server for vscode (#23383) 2023-05-30 18:31:15 -07:00
Andrey Lushnikov
5cd271a2a7
docs: add option clarifications (#23384) 
Fixes https://github.com/microsoft/playwright/issues/23355
 2023-05-30 17:19:48 -07:00
João Neves
7e6e5f0706
feat: Support React forwards refs and memo (#23262) 
This PR fixes the react selector behavior to support components that are
wrapped by the memo or forwardRef React builtin functions.

Previously these components couldn't be selected. This PR fixes that
behavior, enabling selecting those components.

Current behavior:
```
const Foo = memo(() => <div id="foo_component" />);
Foo.displayName = "Foo";
...
playwright.$("_react=Foo") -> undefined
```

Fixed behavior:
```
const Foo = memo(() => <div id="foo_component" />);
Foo.displayName = "Foo";
...
playwright.$("_react=Foo") -> <div id ="foo_component" />
```
 2023-05-30 17:14:47 -07:00
Pavel Feldman
7ad03027fb
chore: remove output dir before each test (#23380) 2023-05-30 16:03:50 -07:00
Dmitry Gozman
6db6498565
chore: replace sigint handler per browser with a single one (#23317) 
Otherwise, multiple sigint handlers (one from each browser) would try to
`process.exit(130)` each.
 2023-05-30 13:54:04 -07:00
Max Schmitt
13f70b6d89
chore: have type modifiers directly on file import (#23337) 2023-05-30 21:11:35 +02:00
Max Schmitt
2710fd8d6f
fix: should be able to upload multiple large files (#23360) 
Fixes https://github.com/microsoft/playwright/issues/23258
 2023-05-30 18:41:09 +02:00
Max Schmitt
d6e24fafe8
docs: specify assertion timeout type (#23333) 
Fixes https://github.com/microsoft/playwright-dotnet/issues/2589
 2023-05-30 18:13:14 +02:00
Max Schmitt
f819b1c72d
fix: trace viewer with global applied background-color (#23362) 
Fixes https://github.com/microsoft/playwright/issues/23275
 2023-05-30 17:58:29 +02:00
Max Schmitt
9e75b95153
fix: display testId as regex in trace-viewer (#23361) 
Fixes https://github.com/microsoft/playwright/issues/23298
 2023-05-30 17:45:48 +02:00
Playwright Service
fda57978e8
feat(webkit): roll to r1857 (#23353) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-05-29 22:56:38 +02:00
Pavel Feldman
ec972fb7c1
chore: make trace viewer self-desctruct on input disconnect (#23291) 2023-05-26 14:54:54 -07:00
Playwright Service
4f3d4c41af
feat(webkit): roll to r1856 (#23310) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-05-26 09:47:03 -07:00
Dmitry Gozman
fa86f2aee0
chore: createHttpServer that destroys sockets upon close (#23294) 
This avoids the server hanging on close.
 2023-05-26 07:03:41 -07:00
Yury Semikhatsky
0ef8832f56
fix: patch project names and ids when merging reports (#23295) 
Project name is used in testId calculation, so patching it in the
reporter is too late. Instead we now save project suffix to the blob
report file and patch all project and test ids as well as project names
in the report merger
 2023-05-25 23:02:23 -07:00
Pavel Feldman
1e95b6d906
chore: allow sending trace URLs over stdin (#23288) 2023-05-25 15:38:47 -07:00
Pavel Feldman
f879ac7e44
chore: report output dir as a part of the list files (#23283) 2023-05-25 15:38:35 -07:00
Tomáš Hübelbauer
e550df060e
Enhance the forbidOnly mode message to guide the user towards the configuration option (#23146) 
Hi, I am putting this PR out as a feeler to see if there's interested in
improving this error message, but the copy is by no means final and I am
open to improvement suggestions.

My intention here is to:
- Explain what a "focused item" is - that we're talking about a test and
it being focused is most likely down it using `only`
  
Are there other types of "items"? Are there other ways to make them
focused other than `only`?

- Explain why we're even in focused mode and how to control it

The default scaffolded Playwright config file includes a forbidMode
expression driven by whether `CI=1` is set.
I ran into this when trying to reproduce a CI issue locally so I had it
set and unknowingly entered focus only mode.
I wasn't aware this mode was a thing because I was using the default
configuration from `npm init` and did not familiarize myself with all
the options in it.

Is there a way to tell if we're in a TypeScript or JavaScript project in
this function? I would use that to display the configuration file name
with the right extension.

---------

Signed-off-by: Tomáš Hübelbauer <tomas@hubelbauer.net>
 2023-05-25 13:32:49 -07:00
Playwright Service
c5c0b9a78b
feat(chromium): roll to r1065 (#23281) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-05-25 13:04:36 -07:00
Playwright Service
af423d1bba
feat(chromium-tip-of-tree): roll to r1118 (#23284) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-05-25 13:04:21 -07:00
Yury Semikhatsky
dce730c3be
fix: consider project suffix when computing id (#23270) 2023-05-25 10:36:34 -07:00
Pavel Feldman
342bae6c59
chore: support esm loader on Node 20 (#23269) 2023-05-24 20:17:44 -07:00
Yury Semikhatsky
bcc711145e
feat(webkit): roll to r1855 (#23267) 2023-05-24 16:09:58 -07:00
Pavel Feldman
64dde29788
chore: move to npx playwright-core install when using core (#23260) 2023-05-24 12:16:59 -07:00
Pavel Feldman
76b4b9dbaf
chore: move transform to its own folder (for loader worker) (#23247) 2023-05-23 21:05:33 -07:00
Pavel Feldman
5926c67703
chore: keep @playwright/test/cli exposed (#23241) 
Fixes https://github.com/microsoft/playwright/issues/23225
 2023-05-23 12:32:44 -07:00
Dmitry Gozman
848f1dff3f
feat(trace): instantiate consoleAPI in popout with correct testIdAttribute (#23238) 2023-05-23 12:17:26 -07:00
Pavel Feldman
6cce93b697
chore: explicit server mode control (#23215) 2023-05-23 10:56:37 -07:00
Pavel Feldman
b814e8a5f1
chore: bring back per test artifacts (#23153) 2023-05-23 09:36:35 -07:00
Jasiel Guillén
700062c836
feat(screenshot): Add customizable color option for masked elements (#23185) 
I added a new option to the screenshot method to customize the color of
the box when we want to mask some elements for the screenshot.

The default color is pink `#FF00FF`, but with this new option you can
specify the color you like the most, like a nice green `#00FF00`:

```js
await page.screenshot({
  mask: [page.locator('div').nth(5)],
  maskColor: "#00FF00",
})
```


![ss](https://github.com/microsoft/playwright/assets/23271049/05f754de-0ba6-47a3-ae3e-769720d3da3b)

---------

Signed-off-by: Jasiel Guillén <darkensses@gmail.com>
 2023-05-22 18:44:44 -07:00
Yury Semikhatsky
10b7cb3979
chore: blob report project suffix (#23212) 2023-05-22 17:54:37 -07:00
Andrey Lushnikov
5f36a2946e
fix: add missing webkit deps on ubuntu 20.04 (#23209) 
Fixes https://github.com/microsoft/playwright/issues/23186
 2023-05-22 15:43:09 -07:00
Pavel Feldman
b9e7a91368
fix(html): fix the filter to respect status (#23208) 2023-05-22 15:35:19 -07:00
Pavel Feldman
ee3864913a
chore: allow stub JSX instances in type module (#23211) 
Fixes https://github.com/microsoft/playwright/issues/23207
 2023-05-22 15:34:50 -07:00
Sander
bb84d42d67
feat(ct): svelte partial update (#23193) 2023-05-22 13:18:56 -07:00
Pavel Feldman
144f8b1495
chore: fix playwright-core cli (#23203) 
Fixes https://github.com/microsoft/playwright/issues/23206
 2023-05-22 12:37:08 -07:00
Pavel Feldman
631edc9744
chore(internal): generate code in jsonl (#23124) 2023-05-20 10:15:33 -07:00
Pavel Feldman
0e1aeaaecf
chore: do not show stale source in the trace (#23163) 2023-05-19 15:18:18 -07:00
Pavel Feldman
bd090e67df
lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
Dmitry Gozman
bd33e5f8c0
fix(tracing): when zipping remotely, use correct file name (#23171) 
Fixes #23108.
 2023-05-19 14:42:01 -07:00
Pavel Feldman
49370cb6fd
chore: fix file view padding (#23166) 2023-05-19 11:07:49 -07:00
Pavel Feldman
2697e93663
chore: do not annotate actions after failed ones as timed out (#23148) 2023-05-18 15:52:44 -07:00
Max Schmitt
9b4f9b1136
docs: add dialog/consoleMessage helper methods for language bindings (#23140) 
https://github.com/microsoft/playwright-dotnet/issues/2565

---------

Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
 2023-05-18 23:47:28 +02:00
Dmitry Gozman
422b65eeae
feat(connect): pw:server:channel and pw:socks debug logs (#23144) 
Fixes #23081.
 2023-05-18 13:44:48 -07:00
Dmitry Gozman
ab7e794bf7
feat(shard): introduce mode: 'default' (#23023) 
This mode allows a suite to opt-out from parallelism. Useful to setup
multiple suites running in parallel, with each suite not being sharded.

References #22891.
 2023-05-18 13:07:22 -07:00
Pavel Feldman
969e5ff1aa
test: add attachment tests (#23143) 2023-05-18 11:48:53 -07:00
Pavel Feldman
3395a28181
chore: opt out of trace attachments (#23139) 
Fixes: https://github.com/microsoft/playwright/issues/23137
 2023-05-18 11:27:45 -07:00
Yury Semikhatsky
a1fc8ff07d
fix: preserve steps in merged report (#23120) 2023-05-18 09:38:49 -07:00
Max Schmitt
acdb71878e
test: unskip selenium driver test (#23129) 
Issue is that [when `stop()` is
called](28504f6dc7/tests/library/browsertype-launch-selenium.spec.ts (L202)),
`onExit()` gets called and then it throws an unhandled rejection.

This regressed in https://github.com/microsoft/playwright/pull/23028.

I didn't find a reason to keep onExit, so removed it for now since
transport should handle these scenarios.

Fixes https://github.com/microsoft/playwright/issues/23110
 2023-05-18 18:33:11 +02:00
Max Schmitt
0c032eb7be
chore: do not read browserslist file (#23127) 
Fixes https://github.com/microsoft/playwright/issues/23125
 2023-05-18 18:11:08 +02:00
Playwright Service
595c4cb855
feat(chromium-tip-of-tree): roll to r1116 (#23131) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-05-18 16:31:08 +02:00
Playwright Service
5957d8f306
feat(chromium): roll to r1064 (#23130) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2023-05-18 15:52:45 +02:00
Playwright Service
28504f6dc7
feat(chromium-tip-of-tree): roll to r1115 (#23109) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-05-18 11:49:35 +02:00
Andrey Lushnikov
b31511e0c9
chore: cut v1.34.0 (#23121) 2023-05-17 19:05:38 -07:00
Dmitry Gozman
be7984bdc9
fix(unroute): do not compare regexp instances (#23101) 
References #23092.
 2023-05-17 16:27:32 -07:00